Closed
Bug 539720
Opened 15 years ago
Closed 15 years ago
cachedNewlineOffset can end up uninitialized
Categories
(Core :: Layout: Text and Fonts, defect, P1)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | alpha1+ |
People
(Reporter: bzbarsky, Assigned: roc)
References
Details
(Keywords: valgrind)
Attachments
(1 file)
|
1.15 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
valgrind says:
==25133== Conditional jump or move depends on uninitialised value(s)
==25133== at 0x52E58F0: nsTextFrame::Reflow(nsPresContext*, nsHTMLReflowMetrics&, nsHTMLReflowState const&, unsigned int&) (nsTextFrameThebes.cpp:6501)
That line is:
6501 } else if (cachedNewlineOffset) {
Is cachedNewlineOffset supposed to be initialized to null, perhaps?
|
Assignee | |
Comment 1•15 years ago
|
||
Er, yeah. (Fortunately, if it's non-null garbage then we just do an unnecessary RemoveProperty call.)
Attachment #421694 -
Flags: review?(bzbarsky)
|
Reporter | |
Updated•15 years ago
|
Attachment #421694 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs landing]
|
|
Reporter | |
Updated•15 years ago
|
blocking2.0: --- → ?
|
|
Assignee | |
Updated•15 years ago
|
blocking2.0: ? → alpha1
Priority: -- → P1
|
|
Assignee | |
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in
before you can comment on or make changes to this bug.
Description
•