Closed Bug 539748 Opened 13 years ago Closed 13 years ago

[qsgen] handle .* and - better

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: vlad, Assigned: vlad)

Details

Attachments

(1 file)

Attached patch patch, v1Splinter Review
We have the ability to do "nsIFoo.*, -nsIFoo.bar" now, but that doesn't currently work if bar isn't valid for quickstubs.  This patch changes things around a bit so that the quickstub list is built up first, taking into account all the additions and removals, and then check the full list at once for validity.  This means that methods that can't be quickstubbed still must be explicitly listed as -, but it makes quickstubbing interfaces that have all good methods and one or two bad ones much simpler.

One quirk is that we add the 'traceable' attr on a member, whereas coming from the parser it could only have 'readonly' or 'optional_argc', so I had to add that to the list of recognized attrnames.
Attachment #421664 - Flags: review?(jorendorff)
Attachment #421664 - Flags: review?(jorendorff) → review+
http://hg.mozilla.org/mozilla-central/rev/8f0bd2ee09f9
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee: nobody → vladimir
You need to log in before you can comment on or make changes to this bug.