Created attachment 421724 [details] [diff] [review] Patch v.1 The UI we show in content for missing/blocked/disabled plugins relies on XBL + CSS pseudoclasses to show the appropriate stuff. See toolkit/mozapps/plugins/content/missingPluginBinding.css Bug 538910 is adding UI here for when a plugin has crashed, and will need similar pseudoclass support. This was pretty easy to do my just copying what Mossop did for bug 391728.
Might be nice to add some appropriate test_parseable() calls in layout/style/test/test_selectors.html . Otherwise looks fine to me, though bzbarsky should probably take a quick look to make sure he doesn't see anything missing.
Looks fine to me.
(Are we sure that the ContentStatesChanged notification is sent whenever we go into or out of this state?)
That seems to be the problem -- bug 539851.
Created attachment 422446 [details] [diff] [review] Patch v.2 Rolled in the trivial fix for bug 539851.
9 years ago
Attachment #422446 - Flags: review?(dbaron) → review+
Created attachment 425564 [details] [diff] [review] Patch v.3 Added tests.
Attachment #422446 - Attachment is obsolete: true
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
http://hg.mozilla.org/projects/firefox-lorentz/rev/6e5f63278c8f dbaron/bz: this was not a completely trivial backport because the table-driven CSS_STATE_PSEUDO_CLASS on trunk is not present on branch. Can you please verify that my patch is correct?
The lorentz patch looks good to me.
Blanket approval for Lorentz merge to mozilla-1.9.2 a=beltzner for 188.8.131.52 - please make sure to mark status1.9.2:.4-fixed
Merged into 1.9.2 at http://hg.mozilla.org/releases/mozilla-1.9.2/rev/84ba4d805430
status1.9.2: --- → .4-fixed
You need to log in before you can comment on or make changes to this bug.