Closed Bug 539828 Opened 11 years ago Closed 11 years ago

Need CSS pseudoclass for crashed plugins

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a2
Tracking Status
status1.9.2 --- .4-fixed

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

(Whiteboard: [fixed-lorentz])

Attachments

(1 file, 2 obsolete files)

Attached patch Patch v.1 (obsolete) — Splinter Review
The UI we show in content for missing/blocked/disabled plugins relies on XBL + CSS pseudoclasses to show the appropriate stuff. See toolkit/mozapps/plugins/content/missingPluginBinding.css

Bug 538910 is adding UI here for when a plugin has crashed, and will need similar pseudoclass support. This was pretty easy to do my just copying what Mossop did for bug 391728.
Might be nice to add some appropriate test_parseable() calls in layout/style/test/test_selectors.html .  Otherwise looks fine to me, though bzbarsky should probably take a quick look to make sure he doesn't see anything missing.
Looks fine to me.
(Are we sure that the ContentStatesChanged notification is sent whenever we go into or out of this state?)
That seems to be the problem -- bug 539851.
Duplicate of this bug: 539851
Attached patch Patch v.2 (obsolete) — Splinter Review
Rolled in the trivial fix for bug 539851.
Attachment #421724 - Attachment is obsolete: true
Attachment #422446 - Flags: review?(dbaron)
Attachment #422446 - Flags: review?(dbaron) → review+
Attached patch Patch v.3Splinter Review
Added tests.
Attachment #422446 - Attachment is obsolete: true
Pushed http://hg.mozilla.org/mozilla-central/rev/939876c7428e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Flags: in-testsuite+
http://hg.mozilla.org/projects/firefox-lorentz/rev/6e5f63278c8f

dbaron/bz: this was not a completely trivial backport because the table-driven CSS_STATE_PSEUDO_CLASS on trunk is not present on branch. Can you please verify that my patch is correct?
Whiteboard: [fixed-lorentz]
The lorentz patch looks good to me.
Blanket approval for Lorentz merge to mozilla-1.9.2
a=beltzner for 1.9.2.4 - please make sure to mark status1.9.2:.4-fixed
You need to log in before you can comment on or make changes to this bug.