539828 - Need CSS pseudoclass for crashed plugins

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

The UI we show in content for missing/blocked/disabled plugins relies on XBL + CSS pseudoclasses to show the appropriate stuff. See toolkit/mozapps/plugins/content/missingPluginBinding.css

Bug 538910 is adding UI here for when a plugin has crashed, and will need similar pseudoclass support. This was pretty easy to do my just copying what Mossop did for bug 391728.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Might be nice to add some appropriate test_parseable() calls in layout/style/test/test_selectors.html .  Otherwise looks fine to me, though bzbarsky should probably take a quick look to make sure he doesn't see anything missing.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Looks fine to me.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Are we sure that the ContentStatesChanged notification is sent whenever we go into or out of this state?)

Comment 4

[Justin Dolske [:Dolske]]

That seems to be the problem -- bug 539851.

Comment 6

[Justin Dolske [:Dolske]]

Attachment: Patch v.2

Rolled in the trivial fix for bug 539851.

Comment 7

[Justin Dolske [:Dolske]]

Attachment: Patch v.3

Added tests.

Comment 8

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/939876c7428e

Comment 9

[Benjamin Smedberg]

http://hg.mozilla.org/projects/firefox-lorentz/rev/6e5f63278c8f

dbaron/bz: this was not a completely trivial backport because the table-driven CSS_STATE_PSEUDO_CLASS on trunk is not present on branch. Can you please verify that my patch is correct?

Comment 10

[Boris Zbarsky [:bzbarsky]]

The lorentz patch looks good to me.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Blanket approval for Lorentz merge to mozilla-1.9.2
a=beltzner for 1.9.2.4 - please make sure to mark status1.9.2:.4-fixed

Comment 12

[Benjamin Smedberg]

Merged into 1.9.2 at http://hg.mozilla.org/releases/mozilla-1.9.2/rev/84ba4d805430