540030 - Display the error and hide the progress bar if an add-on install fails in the Add-on Manager

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

If an error occurs while installing an add-on, there is no error indicated. Also, the progress bar just remains visible.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

* Adds an error msg to the search binding
* Sets the msg if an error occurs
* Uses the platform strings (no l10n impact)
* Hides the progress bar if any error occurs

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 421901 [details] [diff] [review]
patch

>diff --git a/chrome/content/extensions.js b/chrome/content/extensions.js

>   _installCallback: function ev__installCallback(aItem, aStatus) {

>+      try {
>+        var msg = strings.GetStringFromName("error" + aStatus);
>+      } catch (ex) {
>+        msg = strings.getFormattedStringFromName("unknown.error", [aStatus]);

This should be formatStringFromName(), presumably?

Haven't had a chance to test this, but r=me assuming you have.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> (From update of attachment 421901 [details] [diff] [review])
> >diff --git a/chrome/content/extensions.js b/chrome/content/extensions.js
> 
> >   _installCallback: function ev__installCallback(aItem, aStatus) {
> 
> >+      try {
> >+        var msg = strings.GetStringFromName("error" + aStatus);
> >+      } catch (ex) {
> >+        msg = strings.getFormattedStringFromName("unknown.error", [aStatus]);
> 
> This should be formatStringFromName(), presumably?

Yep

> Haven't had a chance to test this, but r=me assuming you have.

Tested for known errors :)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to default:
http://hg.mozilla.org/mobile-browser/rev/a905d05db9e8

Comment 5

[Aakash Desai [:aakashd]]

Is there an extension we can test this against? The problems with lazy click have been fixed too quickly.