Closed Bug 540038 Opened 10 years ago Closed 10 years ago

add warning if configure or config.status are out of date

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: vlad, Assigned: vlad)

References

Details

Attachments

(1 file)

Our toplevel Makefile makes no warning if configure.in changed or if you haven't reran configure after configure changed.  This adds two rules to the toplevel Makefile, to ensure that the user at least has to explicitly skip this step.
Attachment #421911 - Flags: review?(ted.mielczarek)
Comment on attachment 421911 [details] [diff] [review]
check configure freshness

Seems fine. In the line where you say "To ignore this message..." you should probably note that the resulting build may not succeed.
Attachment #421911 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → vladimir
http://hg.mozilla.org/mozilla-central/rev/9b1f6f6aebeb
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
status1.9.1: --- → ?
status1.9.2: --- → ?
Target Milestone: --- → mozilla1.9.3a1
Why not add some rules to automatically rerun autoconf and configure? If you didn't want to put them in the root Makefile itself, you could always put them in a separate Makefile, perhaps calling it client.mk ;-)
Can't, unfortunately -- there are too many automagic environment variables that are used as part of the configure process (not just ours, but configure in general -- e.g. overriding CC).  The automatic rerunning of configure never really works for any project unless the invocation was trivial to begin with.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.