Closed
Bug 540038
Opened 14 years ago
Closed 14 years ago
add warning if configure or config.status are out of date
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: vlad, Assigned: vlad)
References
Details
Attachments
(1 file)
1.12 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Our toplevel Makefile makes no warning if configure.in changed or if you haven't reran configure after configure changed. This adds two rules to the toplevel Makefile, to ensure that the user at least has to explicitly skip this step.
Attachment #421911 -
Flags: review?(ted.mielczarek)
Comment 1•14 years ago
|
||
Comment on attachment 421911 [details] [diff] [review] check configure freshness Seems fine. In the line where you say "To ignore this message..." you should probably note that the resulting build may not succeed.
Attachment #421911 -
Flags: review?(ted.mielczarek) → review+
Updated•14 years ago
|
Assignee: nobody → vladimir
Assignee | ||
Comment 2•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/9b1f6f6aebeb
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Comment 3•14 years ago
|
||
Why not add some rules to automatically rerun autoconf and configure? If you didn't want to put them in the root Makefile itself, you could always put them in a separate Makefile, perhaps calling it client.mk ;-)
Assignee | ||
Comment 4•14 years ago
|
||
Can't, unfortunately -- there are too many automagic environment variables that are used as part of the configure process (not just ours, but configure in general -- e.g. overriding CC). The automatic rerunning of configure never really works for any project unless the invocation was trivial to begin with.
Updated•12 years ago
|
status1.9.1:
? → ---
status1.9.2:
? → ---
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•