Closed Bug 540098 Opened 15 years ago Closed 8 years ago

junk notification bar is very tall

Categories

(Thunderbird :: Message Reader UI, defect)

x86
All
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: andreasn, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [patchlove])

Attachments

(1 obsolete file)

Attached patch gnomestripe fix for the junk bar (obsolete) — Splinter Review
spinning this one off bug 539416 The junk bar is very tall, especially compared to the notification bars in Firefox.
Attachment #421953 - Attachment is patch: true
Attachment #421953 - Attachment mime type: application/octet-stream → text/plain
Depends on: 539416
Blocks: 539416
No longer depends on: 539416
Andreas, is this (and the others) good to go?
Severity: normal → minor
Whiteboard: [patchlove]
This was filed before bug 562048 was filed and later fixed, which reduced the vertical size of notification bars significantly (by using smaller icons, and removing the text link e.g. under the main text of Junk notification bar. So I think the original problem is solved. With the new, slicker bars, just removing the 3px padding as patch suggests will no longer work well as it'll look squeezed. Feel free to reopen if you think otherwise, or if there's something special in Linux which I'm not aware off, but judging from attachment 770403 [details], it looks very much ok to me even on Linux.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Comment on attachment 421953 [details] [diff] [review] gnomestripe fix for the junk bar Also, patch has become obsolete, as there's only one instance where Lightning is still using .msgNotificationBar class, otherwise those classes of patch are unused. https://dxr.mozilla.org/comm-central/search?q=msgNotificationBar&redirect=false
Attachment #421953 - Attachment is obsolete: true
Thanks a lot Andreas for trying to improve this at the time where it was still a problem!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: