540116 - IPDL: In DEBUG builds, a crashed child in ah_crap_handler shouldn't block the parent

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Just need to close the magical fd of the socket connected back to the parent.

Might be worthwhile to have this behavior selected with an environment variable, maybe defaulting to "unblock on crash".

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Unblock the parent if the child crashes in a DEBUG build (by default)

For old behavior, |export MOZ_DONT_UNBLOCK_PARENT_ON_CHILD_CRASH=1|.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Strunk & White note: I used "don't unblock" instead of "block" because the parent won't always be blocked on the child when it crashes, f.e. if the child crashed from an async message.  We can only say that the parent won't be unblocked, we can't say that it will be blocked.

Comment 3

[timeless]

re comment 2: cjones++

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Pushed http://hg.mozilla.org/mozilla-central/rev/4c3d6950eb49

Comment 5

[Peter van der Woude [:Peter6]]

could this have caused Bug 544735 in regular builds ?