Closed Bug 540118 Opened 10 years ago Closed 10 years ago

Remove zoomin / zoomout shortcut keys

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Maemo
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Maemo 5 overides the volume rocker hard keys so they _only_ control volume and do not send the F1 and F2 keys. Maemo 5 update 1.1 seems to allow the F1 and F2 key events to get through, but still controls volume.

The result is Fennec will zoom _and_ the volume changes. Not good. Since it's too late for disabling the volume control, we'll disable the zoom keys.
Attachment #421973 - Flags: review?(pavlov)
This new Maemo behavior only affects the N900, but the patch disables the volume hardkeys for the N810/N800 too.
Attachment #421973 - Flags: review?(pavlov) → review+
pushed to default:
http://hg.mozilla.org/mobile-browser/rev/075ff65da4b7
Assignee: nobody → mark.finkle
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → RC
This is not fixed on trunk on then n810 on build:

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20100119 Firefox/3.7a1pre Fennec/1.1a1pre
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch patch 2Splinter Review
Previous patch removed the zoom key handlers from WINCE, not MAEMO

This patch puts the WINCE handlers back and removes the MAEMO (and desktop) handlers.
Attachment #421973 - Attachment is obsolete: true
Attachment #422399 - Flags: review?(pavlov)
Tested on desktop, N900 and N810 - No more zoom!
Attachment #422399 - Flags: review?(pavlov) → review+
pushed to default (again):
http://hg.mozilla.org/mobile-browser/rev/9538a3e68506
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2pre) Gecko/20100120 Namoroka/3.6pre Fennec/1.0pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20100120 Namoroka/3.7a1pre Fennec/1.01pre
Status: RESOLVED → VERIFIED
Component: Linux/Maemo → General
OS: Linux → Linux (embedded)
QA Contact: maemo-linux → general
Hardware: x86 → ARM
You need to log in before you can comment on or make changes to this bug.