Closed Bug 540212 Opened 13 years ago Closed 13 years ago

ASSERTION: row count did not change by the amount suggested, check caller: 'rowCount == mRowCount' with test_open_first_message_in_smart_inbox in test-deletion-from-virtual-folders.js

Categories

(Thunderbird :: Folder and Message Lists, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1b1

People

(Reporter: rain1, Assigned: rain1)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This is an annoying assertion that seems to happen only with smart folders, and the reason is that smart folders can add folders to the row map during generateMap (<http://mxr.mozilla.org/comm-central/source/mail/base/content/folderPane.js#980>, which results in <http://mxr.mozilla.org/comm-central/source/mail/base/content/folderPane.js#1683>). This causes our oldCount and the real old count to be out of sync.

Not sure how to write an automated test for this, but to manually test, you could run folder-display/test-deletion-from-virtual-folders.js with a debug build and see whether an assertion happens at test_open_first_message_in_smart_inbox.
Attachment #422030 - Flags: review?(bienvenu)
Comment on attachment 422030 [details] [diff] [review]
patch

yay, thx, those assertions were annoying.
Attachment #422030 - Flags: review?(bienvenu) → review+
http://hg.mozilla.org/comm-central/rev/7016cd8f1d27
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
Target Milestone: Thunderbird 3.1a1 → Thunderbird 3.1b1
You need to log in before you can comment on or make changes to this bug.