540353 - dnd folders in bookmarks organizer eats disk, filling /tmp to limit

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Joseph "What is reality?" Brenner]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.13) Gecko/2009080315 Ubuntu/9.04 (jaunty) Firefox/3.0.13
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.13) Gecko/2009080315 Ubuntu/9.04 (jaunty) Firefox/3.0.13

With a large collection of bookmarks (the exported html has 4 megabytes, around 8500 lines), trying to move a relatively big folder around can cause firefox to start thrashing, completely filling /tmp with clipboardcache-* files.  I watched this gradually eat 5gigs of disk... I suspect it continues without limit until the partition is full.  I reproduced this behavior three times before giving up.

Reproducible: Sometimes

Steps to Reproduce:
1. Create a large collection of bookmarks (~8000 entires, with some moderate sub-division into folders)
2. Grab a bigger folder (with around 60 entries), drag it into another folder, then try to drag it up to the top level again.
3. If you get the system to hang-up on you, do a Ctrl-Alt-f4 to get a terminal, watch the disk usage climb by doing a "df" repeatedly.  Look at what's showing up in the /tmp directory. 

Actual Results:  
System freezes up, entire /tmp partition is filled.
If you let it go long enough to fill the disk, you can lose 
data: I blanked out my Profiles.ini file this way and had to 
recreate it manually.


Expected Results:  
My expectation would be that you can move a hundred lines around in a collection of 10000 lines without chugging and thrashing.  

(1)Give me a preference to dump the Icon data in the bookmarks-- I don't care about it, and it eats space. 
(2)Get a better sqlite library?  Let me use a real database instead? 
(3)Force us to use tags instead of physical rearrangment of the data?

This might be related to bug 518583 (and possibly 405765).

Comment 1

[Marco Bonardo [:mak]]

Can you please test this in current Firefox 3.6?

Comment 2

[Tyler Downer [He/Him]]

Reporter, are you still seeing this issue with Firefox 3.6.13 or later in safe mode or a fresh profile? If not, please close. These links can help you in your testing.
http://support.mozilla.com/kb/Safe+Mode
http://support.mozilla.com/kb/Managing+profiles

Comment 3

[Joseph "What is reality?" Brenner]

Well, I just downloaded the Firefox 4 beta, but the Bookmark Manager has gone away, and with it the import/export features, so it wasn't clear to me how to create a mega-byte scale collection of bookmarks for testing purposes... but I took a guess about just copying and old places.sqlite file over and that seems to have worked. 

The default places.sqlite was 1,0485,760 bytes, copying my current one over from a 3.5beta installation  increased it in size to 26,763,264, I picked a folder I know is fairly large and dragged it around into  a few different places without any difficulty.  In fact, it responded much faster than I'm used to seeing with 3.5, the code has clearly been re-written and is responding much faster.  

Nice job.

Comment 4

[Tyler Downer [He/Him]]

nope, bookmark manager is still there. Ctrl+shift+b, or it's also vcalled "show all bookmarks"