Closed Bug 540443 Opened 10 years ago Closed 10 years ago

Change one argument of nsContentUtils::CheckSameOrigin from nsIDOMNode to nsINode

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: peterv, Assigned: peterv)

Details

Attachments

(1 file)

Allows us to remove some QIs.
Attached patch v1Splinter Review
Attachment #422218 - Flags: review?(bzbarsky)
Attachment #422218 - Flags: review?(bzbarsky) → review+
     // This QI is dumb, but this shouldn't be a critical operation
-    nsCOMPtr<nsIDOMNode> domRoot = do_QueryInterface(mRoot);
-    nsresult rv = nsContentUtils::CheckSameOrigin(domRoot, aCurrentNode);
+    nsresult rv = nsContentUtils::CheckSameOrigin(mRoot, aCurrentNode);

I think the comment should be removed, too.
nsContentUtils.h:
@@ -402,9 +402,9 @@ public:
    * a js-object that implements nsIDOMNode.
    * Never call this function with the first node provided by script, it
    * must always be known to be a 'real' node!

this comment is outdated as well, isn't it?
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.