540443 - Change one argument of nsContentUtils::CheckSameOrigin from nsIDOMNode to nsINode

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Allows us to remove some QIs.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 2

[Jonathan Haas]

     // This QI is dumb, but this shouldn't be a critical operation
-    nsCOMPtr<nsIDOMNode> domRoot = do_QueryInterface(mRoot);
-    nsresult rv = nsContentUtils::CheckSameOrigin(domRoot, aCurrentNode);
+    nsresult rv = nsContentUtils::CheckSameOrigin(mRoot, aCurrentNode);

I think the comment should be removed, too.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

nsContentUtils.h:
@@ -402,9 +402,9 @@ public:
    * a js-object that implements nsIDOMNode.
    * Never call this function with the first node provided by script, it
    * must always be known to be a 'real' node!

this comment is outdated as well, isn't it?

Comment 4

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/mozilla-central/rev/582494927009
http://hg.mozilla.org/mozilla-central/rev/d632fb50f68d
http://hg.mozilla.org/mozilla-central/rev/2caefaaa7d77