Closed
Bug 540443
Opened 15 years ago
Closed 15 years ago
Change one argument of nsContentUtils::CheckSameOrigin from nsIDOMNode to nsINode
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: peterv, Assigned: peterv)
Details
Attachments
(1 file)
4.31 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Allows us to remove some QIs.
Assignee | ||
Comment 1•15 years ago
|
||
Attachment #422218 -
Flags: review?(bzbarsky)
![]() |
||
Updated•15 years ago
|
Attachment #422218 -
Flags: review?(bzbarsky) → review+
Comment 2•15 years ago
|
||
// This QI is dumb, but this shouldn't be a critical operation
- nsCOMPtr<nsIDOMNode> domRoot = do_QueryInterface(mRoot);
- nsresult rv = nsContentUtils::CheckSameOrigin(domRoot, aCurrentNode);
+ nsresult rv = nsContentUtils::CheckSameOrigin(mRoot, aCurrentNode);
I think the comment should be removed, too.
Comment 3•15 years ago
|
||
nsContentUtils.h:
@@ -402,9 +402,9 @@ public:
* a js-object that implements nsIDOMNode.
* Never call this function with the first node provided by script, it
* must always be known to be a 'real' node!
this comment is outdated as well, isn't it?
Assignee | ||
Comment 4•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/582494927009
http://hg.mozilla.org/mozilla-central/rev/d632fb50f68d
http://hg.mozilla.org/mozilla-central/rev/2caefaaa7d77
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•