540531 - Freeze the refresh driver in bfcached pages

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This will mean we don't process restyles (and soon reflows) in them even if someone messes with content states, say.  I believe this is in fact desirable.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Freeze() and Thaw() should assert about the current state of mFrozen (not what they're setting it to).

I think Thaw() should synchronously do a refresh.  Or would synchronous be a problem?  If so, it should probably be immediately and not after the timer interval.

Other than that, I think this looks fine.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 422287 [details] [diff] [review]
Like so

Marking review- to prompt response to comment above.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Sync is a problem in general due to it possibly running script.  I'll make it async and ASAP.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Updated patch

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 423120 [details] [diff] [review]
Updated patch

ok, r=dbaron

Comment 7

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/5ea413d845bf