Closed Bug 54057 Opened 24 years ago Closed 24 years ago

spellchecking not working

Categories

(Core :: DOM: Editor, defect, P1)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: sujay, Assigned: ccarlen)

References

Details

(Whiteboard: [nsbeta3-][p:1][rtm+ NEED INFO])

Attachments

(1 file)

patch
2.35 KB, patch
Details | Diff | Splinter Review 
using 9/25 branch build..

1) launch netscape
2) launch composer
3) insert text: ";ljfg;jg"
4) click on spellcheck button

nothing comes up.
Accepting bug.

Sujay, if you look in the components directory of your install, is there a 
spellchecker directory?
Severity: normal → critical
Status: NEW → ASSIGNED
Keywords: nsbeta3, rtm
Priority: P3 → P1
Summary: spellchecking not working → spellchecking not working
Target Milestone: --- → M18
yes there is a spellchecker directory in that folder.
There are 2 problems:

1. You can't invoke the spellchecker via the toolbar. This is probably caused by 
the same thing causing bug #54018.

2. vishy@netscape.com made some changes to the spellchecker without my 
knowledge, which removed the trailing '\\' from the spellchecker directory 
string I create. This trailing slash is needed by the INSO spellchecker library! 

The checkin I refer to in #2 is:

http://warp.mcom.com/webtools/bonsai/cvsview2.cgi?diff_mode=context&whitespace_m
ode=show&file=nsSpellCheckGlue.cpp&root=/m/src&subdir=ns/modules/spellchk/glue&c
ommand=DIFF_FRAMESET&rev1=1.21&rev2=1.22
Status: ASSIGNED → NEW
must fix
Whiteboard: [nsbeta3+]
apologize for that muck-up. conrad said that we have to remove all usage of
nisfilelocations from the commercial tree and that was the patch to do that.
i think i shd have reviewed it more carefully and tested better - i apologize
for that. Conrad - can you explain to kin what that change was all about.
thanks,Vishy

Kin, these changes were needed to get rid of nsIFileLocator which is bug 38626.
On my Mac build at the time I made those changes, I was not able to get
spellcheck to work even before applying my changes, Thinking it was something
wrong with my build, I sent it off for review and asked for close review of
these changes. My fault. I'll take a look now.

Have fix tested for Mac. Checking Win now. One thing I noticed was that the
custom dictionary is called "custom.dic" on all platforms. Shouldn't it be
called "Custom Dictionary" on the Mac? When a 4.x profile is migrated, the file
"Custom Dictionary" is migrated. If this dictionary is of the current format,
and I assume it is or why migrate it, don't we want to use the same name for the
file? If it is of different format, of course, we need to use a new name.

*** Bug 54178 has been marked as a duplicate of this bug. ***
Attached patch patch — — Splinter Review 

    
    

    
  
We will have to release note this if this is not going to be in PR3.

Keywords: relnote3

    
    

    
  
The above patch was tested on Mac, Win, & Linux. On all 3, I was not able to
bring up spellcheck today by the toolbar. This code was never reached. Using the
menubar, it was reached and worked.


    
    

    
  
The fact that the spellchecker dialog doesn't launch from the toolbar is due 
to bug #54018.

You are correct about the "Custom Dictionary" name on the mac, we should 
probably add some ifdef XP_MAC code to use that name.

I noticed that the spellchecker actually works on the Netscape_20000922_BRANCH 
which means your changes to get rid of nsIFileLocator are only on the tip ... 
are you planning on landing these changes on the branch?

I'll give your patch a try as soon as my Tip Mozilla and Commercial build is 
done.
Status: NEW → ASSIGNED

    
    

    
  
Thanks. Adding the #ifdef XP_MAC would be a good thing. Yes, they do need to
land on the branch. Once all is well on the trunk...


    
    

    
  
Cc sfraser@netscape.com so he can review the mac specific parts of the patch.

    
    

    
  
Filed the need to rename "custom.dic" to "Custom Dictionary" for the Mac as 
bugscape #2542.

I just tried the patch on Linux and it seems to fix the problem. It's a bummer 
that we have to use 2 different string classes to append a slash though. ;-)

I notice that you added some code to stat and create the custom dictionary. That 
code shouldn't be neccessary since the INSO library does that for us.

I believe sfraser said the mac portion looked ok.

r=kin@netscape.com

Do you want me to reassign this bug to you?

    
    

    
  
*** Bug 54297 has been marked as a duplicate of this bug. ***

    
    

    
  
Marking nsbeta3- as I don't think that it is absolutely necessary to hold pr3
for this.  Also, according to Phil Peterson, this bug is wfm in today's branch
build.  The bug is already nominated for rtm.

Whiteboard: [nsbeta3+] → [nsbeta3-]

    
    

    
  
I think that bugscape 2542 should be fixed on this checkin since it is so simple
to do. The reason I check for and create the custom dict file so that I could
get a valid FSSpec out of it on the Mac. This is bug 51932 which is fixed and
sent for review Mon. Rather than making this bug depend on that one, I just
checked for and created the file if need be, thus working around that one.


    
    

    
  
adding rtm+

Whiteboard: [nsbeta3-] → [nsbeta3-][rtm+]
Depends on: 38626

    
    

    
  
spellcheck needs to be functional for rtm

Whiteboard: [nsbeta3-][rtm+] → [nsbeta3-][p:1][rtm+]

    
    

    
  
spellcheck is one sick puppy, i had a long talk with Kin and several items need 
to be cleaned up, this is an extremely visible feature and is highly used, it 
needs to be functional.

Kin, please include the required information per the rtm checkin rules
Whiteboard: [nsbeta3-][p:1][rtm+] → [nsbeta3-][p:1][rtm+ NEED INFO]

    
    

    
  
m19
Target Milestone: M18 → M19
Keywords: mailtrack

    
    

    
  
Reassigning to ccarlen@netscape.com.

Assignee: kin → ccarlen
Status: ASSIGNED → NEW

    
    

    
  
Adding myself to the Cc list.

    
    

    
  
I just checked the patch I posted here on both Mac and Win and it works. kin has
reviewed that patch. Can anybody cc'd here give sr? Simon? Is the problem only
on the trunk?

Status: NEW → ASSIGNED

    
    

    
  
The spellchecker is only broken on the commercial trunk. If you land your
changes that get rid of nsIFileLocator onto the Netscape_20000922_BRANCH, you
will need to make sure that you include the patch for this bug.


    
    

    
  
Have r= and sr=. Nominating for nsbeta3+ so I can check into trunk.


    
    

    
  
We're not doing nsbeta3+ nominations anymore. I believe you are clear to land on
the TRUNK since you have a go from sfraser and I.

    
    

    
  
Oh well, that's what it says on commercial TinderBox. Anyway, the fix is checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED

    
    

    
  
verified fixed on commercial builds
windows 2000-10-16-06-Mtrunk
linux 2000-10-16-06-Mtrunk
mac 2000-10-16-08-Mtrunk
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: