Closed
Bug 540638
Opened 15 years ago
Closed 14 years ago
[z] Populate sphinx with collection data
Categories
(addons.mozilla.org Graveyard :: Search, defect, P1)
addons.mozilla.org Graveyard
Search
Tracking
(Not tracked)
RESOLVED
FIXED
5.9
People
(Reporter: clouserw, Assigned: davedash)
References
Details
(Whiteboard: [z][remora?][qa!])
Attachments
(1 file)
8.23 KB,
patch
|
clouserw
:
review+
jsocol
:
feedback+
|
Details | Diff | Splinter Review |
Right now we have a collections_search_summary table that is used by remora to search collections data. We should use sphinx for this in zamboni and let that table die with remora. Low priority for this milestone
Reporter | ||
Comment 1•14 years ago
|
||
Collections is a P1 for 5.9
Priority: P4 → P1
Target Milestone: 5.6 → 5.9
Assignee | ||
Comment 2•14 years ago
|
||
Remora needs to be tested to verify that multiple indexes don't screw us up. Currently we search all indexes which for now is just addons. According to jsocol, this should still "just work" in remora. In Zamboni we might not need to do anything, until we actually start searching collections.
Whiteboard: [z] → [z][remora?][qa!]
Assignee | ||
Comment 3•14 years ago
|
||
Wil, r this after code-freeze and after jsocol f+'s. James please sanity check this.
Attachment #433147 -
Flags: review?(clouserw)
Attachment #433147 -
Flags: feedback?(james)
Assignee | ||
Comment 4•14 years ago
|
||
QA Notes (for when it lands): Nothing on the zamboni or remora search should change, please verify that there are no Search regressions. Once this bug is marked fix, please open search regressions in a new bug - since they may not be related to this change. -d
Status: NEW → ASSIGNED
Comment 5•14 years ago
|
||
Comment on attachment 433147 [details] [diff] [review] Added collections indexing. I don't have recent data to test this on, but the general approach looks good to me. Much better than repeating the charset_table. Is there a reason you're using stemming for collections?
Attachment #433147 -
Flags: feedback?(james) → feedback+
Assignee | ||
Comment 6•14 years ago
|
||
james - Yes, most collections are going to index real words as opposed to names of addons. So stemming makes more sense than infix.
Reporter | ||
Updated•14 years ago
|
Attachment #433147 -
Flags: review?(clouserw) → review+
Assignee | ||
Comment 7•14 years ago
|
||
r65371
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•