540643 - Advance Search:Platform specific search is not honored

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Search, defect, P3)

Description

[Pratibha]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9.1.3) Gecko/20091026 Firefox/3.5.3
Build Identifier: 

Advance Search does not filter the results as per the given search criteria

Reproducible: Always

Steps to Reproduce:
1. Go to AMO Staging server: http://preview.addons.mozilla.org
2. Expand Advance Search
3. Specify some search criteria
for eg: 
on Linux box select as follows:
- Search = cooliris
- Advanced search: platform=Windows
- Click on Go button

regression:https://bugzilla.mozilla.org/show_bug.cgi?id=504188
Actual Results:  
the results display cooliris with "Add to Firefox(Linux)" though expected result is to display cooliris with "Add to Firefox(Linux)"

Expected Results:  
Advance Search filters the results as per the search criteria

Advance search functionality is also seen broken with "Applications","Last Updated","Platform"

Comment 1

[Pratibha]

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7

Comment 2

[Pratibha]

In my Steps to reproduce: I have done a typo error
Actual Results:  
the results display cooliris with "Add to Firefox(Linux)" though expected
(Windows)

Advance Search Criteria Fails in following condition too:

Last Updated:
Application: Firefox, Platform = Windows, Last Updated = Last Month

Result displays outside the Last Updated timemark
for eg: it displays:  googlebar: Updated July 27,2008, Red Cats(green flavor): June 7,2009 etc..

Application: 
Application - Sunbird

Result:
Firefox browser specific addon are displayed for eg: own 2.4.0, AutoPager etc..

Comment 3

[Pratibha]

Advance search criteria fails with user selection of Version:
- Click on "Advance Search" and in drop-down select version=3.6
- Search for add-on googlebar

Result: googlebar is displayed which "Works with: Firefox: 1.5b1 – 3.0.*" is displayed
Note: In the refine results: 3.6 version is selected, but an add-on for a different version range is being displayed

Comment 4

[krupa raj[:krupa]]

FF version:3.6
platform=MACOSX

steps to reproduce:
Search for add-ons with platform=MACOSX and version=3.6

expected results:
Only add-ons which are supported on MACOSX are returned

actual results:
add-ons not supported on MACOSX are also returned.

URL:https://preview.addons.mozilla.org/en-US/firefox/search?q=&cat=1%2C5&advancedsearch=1&as=1&appid=1&lver=3.6&atype=0&pp=20&pid=3&sort=&lup=

add-on:Image Assistant is not supported on MACOSX but is still listed

Also see-https://preview.addons.mozilla.org/en-US/firefox/addons/versions/790
This add-on has no version which was supported on MACOSX.

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Easy fix:

Sphinx needs to change this:

    SELECT \
        (name.autoid*100+IFNULL(av.application_id,0)) id, \
        IFNULL(platform_id,1) AS platform \
    FROM \
        (translations name, addons a) \
    LEFT JOIN versions v ON v.addon_id = a.id \
    LEFT JOIN applications_versions av ON av.version_id = v.id \
    LEFT JOIN files f ON f.version_id = v.id \
    WHERE \
        a.name = name.id

to:

    SELECT \
        (name.autoid*100+IFNULL(av.application_id,0)) id, \
        IFNULL(platform_id,1) AS platform \
    FROM \
        (translations name, addons a) \
    LEFT JOIN versions v ON v.addon_id = a.id \
    LEFT JOIN applications_versions av ON av.version_id = v.id \
    JOIN files f ON f.version_id = v.id \
    WHERE \
        a.name = name.id

Although this could get way more complicated if we restrict to just the current version addon...

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Fixed:

https://preview.addons.mozilla.org/en-US/firefox/search/?q=image+assistant&cat=1%2C5&lver=3.6&atype=0&sort=&pid=3&pp=20&lup=&advanced=

via:

http://github.com/jbalogh/zamboni/commits/0a21890

Comment 7

[Pratibha]

Advance Search is dropped in AMO now.marking as Verified/Fixed