Closed Bug 540726 Opened 13 years ago Closed 13 years ago

User units for angles should be degrees

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: longsonr, Assigned: longsonr)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Passes the SVGAnimatedAngle test in http://dev.w3.org/SVG/profiles/1.1F2/test/svg/types-dom-04-b.svg with this patch.
Attachment #422416 - Attachment is patch: true
Attachment #422416 - Flags: review?(jwatt)
Assignee: nobody → longsonr
Comment on attachment 422416 [details] [diff] [review]
patch

Can you add a mochitest for this?
Attachment #422416 - Flags: review?(jwatt) → review+
Attached patch with testSplinter Review
Attachment #422416 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/bcd9709de08a
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
The patch made nsSVGAngle::GetAnimValue() return a value in degrees instead of radians (which is correct), but GetAnimValue() is used internally in nsSVGMarkerElement::GetMarkerTransform() where radians is assumed. I included a small fix for this in the patch for bug 545042 as detailed in bug 545042 comment 3.
Depends on: 545042
You need to log in before you can comment on or make changes to this bug.