User units for angles should be degrees

RESOLVED FIXED

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: longsonr, Assigned: longsonr)

Tracking

Trunk
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Created attachment 422416 [details] [diff] [review]
patch

Passes the SVGAnimatedAngle test in http://dev.w3.org/SVG/profiles/1.1F2/test/svg/types-dom-04-b.svg with this patch.
(Assignee)

Updated

9 years ago
Attachment #422416 - Attachment is patch: true
Attachment #422416 - Flags: review?(jwatt)
(Assignee)

Updated

9 years ago
Assignee: nobody → longsonr
Comment on attachment 422416 [details] [diff] [review]
patch

Can you add a mochitest for this?
Attachment #422416 - Flags: review?(jwatt) → review+
(Assignee)

Comment 2

9 years ago
Created attachment 423496 [details] [diff] [review]
with test
Attachment #422416 - Attachment is obsolete: true
(Assignee)

Comment 3

9 years ago
http://hg.mozilla.org/mozilla-central/rev/bcd9709de08a
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
The patch made nsSVGAngle::GetAnimValue() return a value in degrees instead of radians (which is correct), but GetAnimValue() is used internally in nsSVGMarkerElement::GetMarkerTransform() where radians is assumed. I included a small fix for this in the patch for bug 545042 as detailed in bug 545042 comment 3.
Depends on: 545042
You need to log in before you can comment on or make changes to this bug.