Closed Bug 540775 Opened 12 years ago Closed 12 years ago

[OOPP] Implement NPP_SetValue for NPNVprivateModeBool (test_privatemode.xul broken)

Categories

(Core :: Plug-ins, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file)

Implement NPP_SetValue for NPNVprivateModeBool
Attachment #422474 - Flags: review?(jones.chris.g)
Comment on attachment 422474 [details] [diff] [review]
fix test_privatemode.xul, rev. 1

>diff --git a/dom/plugins/PluginInstanceChild.cpp b/dom/plugins/PluginInstanceChild.cpp
>--- a/dom/plugins/PluginInstanceChild.cpp
>+++ b/dom/plugins/PluginInstanceChild.cpp
> bool
>+PluginInstanceChild::AnswerNPP_SetValue_NPNVprivateModeBool(const bool& value,
>+                                                            NPError* result)
>+{
>+    NPBool v = value;
>+    *result = mPluginIface->setvalue(GetNPP(), NPNVprivateModeBool, &v);
>+    return true;
>+}
>+

As we discussed on IRC, the |NPBool| values shouldn't be put on the stack and have their addresses handed to plugins, because flash (at least) treats them as machine-word sized even though they're defined to be a single byte.

r+ with that fixed.
Attachment #422474 - Flags: review?(jones.chris.g) → review+
Depends on: 540776
http://hg.mozilla.org/mozilla-central/rev/ade5875de1b8
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 544158
You need to log in before you can comment on or make changes to this bug.