Closed Bug 540776 Opened 15 years ago Closed 15 years ago

[OOPP] Initialize NPRuntime scriptable result variants

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file)

Initialize result variants, rev. 1
2.55 KB, patch
cjones
: review+
Details | Diff | Splinter Review 
NPRuntime methods such as invoke have a NPVariant *result parameter. I've found that our testplugin (and probably therefore plugins out in the wild) will return `true` from the method without initializing the result to anything, and rely on the fact that our plugin host initializes the result to NPVariantType_Void. The OOPP host should do the same. This happens to be necessary for our tests, including the timer and privatemode test methods.

        Attachment #422477 -
        Flags: review?(jones.chris.g)

        Attachment #422477 -
        Flags: review?(jones.chris.g) → review+

    
  
Blocks: 540775

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/2bcf4c9570dc
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: