540802 - Add-on links double-escaped on Customization page

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Justin Scott [:fligtar]]

On http://www-3.6.stage.mozilla.com/en-US/firefox/customize/ in the Collections section, all of the add-on links have tracking codes, which is great.

However, it seems that the collection GUIDs are being double escaped, and then when they are passed to AMO they're escaped even further. The metrics download counting scripts are picky, and this weird-looking data might lead to the download not being counted at all.

Can we either fix the entities or remove the collection_uuid parameter? (it's not needed -- src is the only important one)

Also related: the collection links themselves are weird: https://addons.mozilla.org/collection/travel&src=fxcustomization

The & would normally be a ? but the src code actually won't make a different on collection links, so they could be removed.

Comment 1

[Steven Garrity [:sgarrity]]

Justin, can you give me an example of what the collection links should look like?

Comment 2

[Justin Scott [:fligtar]]

Sure.

Collection links (the ones that say "Check out the [x] collection" shouldn't have a parameter, like so: https://addons.mozilla.org/collection/travel

All of the add-ons in that box can have the collection_uuid parameter removed, like so:
https://addons.mozilla.org/en-US/firefox/addon/1117?src=fxcustomization

Thanks!

Comment 3

[Steven Garrity [:sgarrity]]

Thanks for the clarification. Done in r60588.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Steven: the first part of comment 2 doesn't appear to have been addressed; I still see https://addons.mozilla.org/collection/travel&src=fxcustomization, where I think it should just be https://addons.mozilla.org/collection/travel

Comment 5

[Steven Garrity [:sgarrity]]

Stephen - thanks, re-fixed in trunk in r60774.

Comment 6

[Steven Garrity [:sgarrity]]

Merged to stage in r60776.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://www.authstage.mozilla.com/en-US/firefox/customize/.