541063 - "Ok" button in open file dialog remains inactive when form is right-clicked

Status: VERIFIED WORKSFORME

(Core Graveyard :: File Handling, defect)

Description

[Laurens Greven]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7

When you hold the right-mouse button (just) before an "opening file" dialog (with the options "open with"/"save as") is triggered , and release the right-mouse button on this dialog, the "Ok" button remains inactive/goes inactive, rendering the form unusable.

Note: you have to hold the right-mouse button -before- the "opening file" dialog appears.

Reproducible: Always

Steps to Reproduce:
1. I've set up a test page at: http://sec.bitsofspy.net/mozilla/bug.htm*, go there.
2. Click the "demo link", and immediately hold the right-mouse button down.
3. When the form appears, hover your mouse on the "opening as" form, and release your right-mouse button. Keep watching the OK button.

*I've also uploaded this document as an attachment, but you will need to create a file called "demo.file" (content doesn't matter) in the same folder to make it work.
Actual Results:  
The "OK" button (that should be "activated") remains inactive, and unusable. The form is broken.

Expected Results:  
The OK button should have become active.

about:buildconfig (doubt it's relevant)

Source

Built from http://hg.mozilla.org/releases/mozilla-1.9.1/rev/655f0b1c7f6a
Build platform
target
i686-pc-mingw32

Build tools
Compiler 	Version 	Compiler flags
cl 	14.00.50727.762 	-TC -nologo -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1
cl 	14.00.50727.762 	-GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1

Configure arguments
--enable-application=browser --enable-update-channel=release --enable-update-packaging --enable-jemalloc --enable-official-branding --disable-tests --with-crashreporter-enable-percent=10

Comment 1

[Laurens Greven]

Attachment: HTML testcase for bug. Instructions within.

HTML testcase for bug. Instructions within.

Comment 2

[Laurens Greven]

Attachment: Screenshot of the bug.

Screenshot of the bug, can be reproduced using my uploaded HTML testcase. I've also uploaded the testcase: http://sec.bitsofspy.net/mozilla/ok_button_bug.htm

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As what I can see is that you are using extensions especially one which overlays this dialog. I suspect that this is the cause. Can you please run Firefox in Safe Mode (http://support.mozilla.com/kb/Safe+Mode) and test again with all add-ons disabled?

Comment 4

[Laurens Greven]

(In reply to comment #3)
> As what I can see is that you are using extensions especially one which
> overlays this dialog. I suspect that this is the cause. Can you please run
> Firefox in Safe Mode (http://support.mozilla.com/kb/Safe+Mode) and test again
> with all add-ons disabled?

It also works when I boot in Safe Mode, with all add-ons disabled. I took a screenshot and will now add it as attachment.

Comment 5

[Laurens Greven]

Attachment: Screenshot of the bug, I've disabled add-ons this time.

Added this screenshot in reply to https://bugzilla.mozilla.org/show_bug.cgi?id=541063#c3

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Do you also see this behavior for known MIME types like .exe, .zip, or whatever else is listed under Applications in the preference window?

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I mean in such a case with the system level save as dialog.

Comment 8

[Laurens Greven]

(In reply to comment #6)
> Do you also see this behavior for known MIME types like .exe, .zip, or whatever
> else is listed under Applications in the preference window?

Yes. I just changed my demo at http://sec.bitsofspy.net/mozilla/ok_button_bug.htm - the file being used now is called "demo.zip". The bug is still reproducible. Feel free to check out my updated demo: http://sec.bitsofspy.net/mozilla/ok_button_bug.htm

(In reply to comment #7)
> I mean in such a case with the system level save as dialog.

The bug happens in the "opening file" dialog, not the "save as".

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, I was able to reproduce with Firefox 3.5.8pre but not with Firefox 3.6. Can you please check the 3.6 release and test if it works for you now?

Comment 10

[Laurens Greven]

(In reply to comment #9)
> Ok, I was able to reproduce with Firefox 3.5.8pre but not with Firefox 3.6. Can
> you please check the 3.6 release and test if it works for you now?


Curious, I am also unable to reproduce the bug in Firefox 3.6 (build 20100115144158). However, the bug is "back" in Firefox 3.5.7.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that it has been fixed at some point in the development process of Firefox 3.6. Given that this is not a security and stability issue I don't believe that it will get fixed for Firefox 3.5.x.

Marking as WFM based on the results with Firefox 3.6

Comment 12

[Laurens Greven]

I'd rather we(In reply to comment #11)
> Given that it has been fixed at some point in the development process of
> Firefox 3.6. Given that this is not a security and stability issue I don't
> believe that it will get fixed for Firefox 3.5.x.
> 
> Marking as WFM based on the results with Firefox 3.6

I'd rather we file it as "verified", with a "wontfix" label. I'm going to take initiative here, and change the status. I understand it's a minor bug, however, since we are able to reproduce it with the latest stable version of Firefox, I don't think you can say it "worksforme".

Also, the "fix" in 3.6 can very well be a glitch, ie. it wasn't patched on purpose.

Comment 13

[Shawn Wilsher :sdwilsh]

(In reply to comment #12)
> I'd rather we file it as "verified", with a "wontfix" label. I'm going to take
> initiative here, and change the status. I understand it's a minor bug, however,
> since we are able to reproduce it with the latest stable version of Firefox, I
> don't think you can say it "worksforme".
I'm sorry, but it doesn't work that way.  We won't fix it on 1.9.1, but it is fixed, and therefore WORKSFORME since we don't know what change fixed it offhand.  Also note that the latest stable version of Firefox is Firefox 3.6.

> Also, the "fix" in 3.6 can very well be a glitch, ie. it wasn't patched on
> purpose.
But that's highly unlikely, but it's not worth the time sifting through the thousands of bugs fixed to find the one that actually fixed this.

Comment 14

[Laurens Greven]

Ugh, stupid stupid stupid- Only know I "realize" that 3.6 isn't 3.5.6, sorry for having reopened the bug before, and thanks for the (already made) fix.