Closed Bug 541131 Opened 10 years ago Closed 10 years ago

IPDL: Include headers as |include protocol PFoo;|, like Java's |import|

Categories

(Core :: IPC, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: cjones, Assigned: bugzilla)

Details

(Whiteboard: [good first bug])

Attachments

(2 files)

Saying |include protocol "PFoo.ipdl";| is redundant, because the IPDL compiler already knows what PFoo's filename will be and expects that file to be in the IPDL search path.
Implemented as described. Change to the parser was relatively simple, but it obviously affected a bunch of IPDL files across the code base. Hopefully I got them all!
Thomas: you should set the review? flag on this patch to get some eyes on it and hopefully get it committed.
Comment on attachment 423484 [details] [diff] [review]
Patch, revision #1 (all changes)

Thanks Thomas!
Attachment #423484 - Flags: review+
I re-added the |include protocol "Foo.ipdl"| syntax so that we can print a more informative error message.

This is going to set e10s on fire when backported, but this patch relies on too much stuff in my queue for me to write an antidote patch.  It's easy to fix these with sed.
Attachment #439319 - Flags: review?(bent.mozilla)
Comment on attachment 439319 [details] [diff] [review]
Updated to m-c latest

Oops, I've been r?ing bent so much today it's in my muscle memory ;).
Attachment #439319 - Flags: review?(bent.mozilla)
http://hg.mozilla.org/mozilla-central/rev/b8d2f3a6b397
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee: nobody → bugzilla
You need to log in before you can comment on or make changes to this bug.