The default bug view has changed. See this FAQ.

Blackwood Makefiles need to be modified for commercial builds

RESOLVED FIXED

Status

Core Graveyard
Java APIs to WebShell
P3
normal
RESOLVED FIXED
17 years ago
5 years ago

People

(Reporter: Ashu Kulkarni, Assigned: Ashu Kulkarni)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(13 attachments)

4.05 KB, application/octet-stream
Details
12.69 KB, patch
Details | Diff | Splinter Review
1.25 KB, patch
Details | Diff | Splinter Review
4.67 KB, patch
Details | Diff | Splinter Review
1.54 KB, application/octet-stream
Details
2.91 KB, patch
Details | Diff | Splinter Review
1.67 KB, patch
Details | Diff | Splinter Review
1.52 KB, patch
Details | Diff | Splinter Review
997 bytes, application/octet-stream
Details
853 bytes, patch
Details | Diff | Splinter Review
2.14 KB, patch
Details | Diff | Splinter Review
2.18 KB, patch
Details | Diff | Splinter Review
5.28 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

17 years ago
Blackwood Makefiles (mozilla/java/Makefile) need to be set up to 
1. Build all Blackwood components - presently pluglets does not get built
2. Check if Commercial Build and 
	a) Version the Blackwood components
	b) Put in separate DEST_PATH
(Assignee)

Comment 1

17 years ago
I submitted, I accept
Status: NEW → ASSIGNED

Comment 2

17 years ago
Added CC: edburns
(Assignee)

Comment 3

17 years ago
Created attachment 15999 [details]
tar.gz of Modified Makefiles - untar in /mozilla
(Assignee)

Comment 4

17 years ago
Created attachment 16000 [details] [diff] [review]
cvs diff -u of Modified Makefiles
(Assignee)

Comment 5

17 years ago
3 files were modified and a new file runem_commercial.pl was added to src_share
directory. Now the java/Makefile builds util, dom, plugins and webclient in that
order.

Also, the webclient/src_moz and webclient/classes_spec Makefiles version the
binaries, create the blackwood.jar and version it and move all the binaries to
the appropriate directory if the Env Variable PACKAGE_BUILD is set.

Ed, pls test this and let me know if I have r=a=edburns.


thanks
_Ashu
(Assignee)

Comment 6

17 years ago
Created attachment 16555 [details] [diff] [review]
cvs diff -u of webclient/classes_spec/Makefile.in

Comment 7

17 years ago
Looks good.  r=edburns.
(Assignee)

Comment 8

17 years ago
Created attachment 16664 [details] [diff] [review]
cvs diff -u (changes in src_moz, classes_spec and java Makefiles)

Comment 9

17 years ago
r=edburns
a=edburns

Check this in.

Comment 10

17 years ago
Created attachment 16742 [details]
changed make files for pluglets

Comment 11

17 years ago
Makefiles  for pluglets.
In  case PACKAGE_BUILD is set 
  pluglet jars go to $(DIST)/javadev/examples
  htmls for sample pluglets go to $(DIST)/javadev/html
  data for sample pluglets go to $(DIST)/javadev/misc

In other case

pluglet jars go to $(DIST)/bin/plugins
htmls and data go to $(DIST)/bin/res/javadev/pluglets

In  last case htmls are accesible via resource:///res/javadev/pluglets/
(resource:///res/javadev/pluglets/zip.html for example)

Comment 12

17 years ago
Created attachment 16743 [details] [diff] [review]
cvs diff -u  of pluglets
(Assignee)

Comment 13

17 years ago
Created attachment 16778 [details] [diff] [review]
cvs diff -u for Makefiles to fix build error
(Assignee)

Comment 14

17 years ago
Igor, pls check in your changes if you haven't already. Shirley will do another
build today afternoon and by today evening, we should have all the build issues
resolved.

Ed, your changes to java/Makefile.in (unjarring) does not work. If make sees a
export:: target in java/Makefile, it does not cd past the first Makefile in each
of the subdirs. i.e. only the Java Makefiles get built for all the projects and
neither the native code, nor the package directories get generated.

I have checked in changes to fix this and tested it. Pls let me know if I have
r=a=edburns

thanks
_Ashu

Comment 15

17 years ago
Sure, I'm sorry I broke this.  r=a=edburns.

Comment 16

17 years ago
I just checked in makefiles for pluglets
Thanks,
  Igor
(Assignee)

Comment 17

17 years ago
Created attachment 16890 [details] [diff] [review]
cvs diff -u java/webclient/src_moz/Makefile.in
(Assignee)

Comment 18

17 years ago
Last modification - minor change fo removing .so files from dist/bin
and dist/lib for commercial builds. they should be only in dist/javadev
Changes made to webclient/src_moz/Makefile.in

_Ashu

Comment 19

17 years ago
r=a=edburns for first 10/12 attachment.

Comment 20

17 years ago
Created attachment 16918 [details]
tar.gz of all files in this iteration.

Comment 21

17 years ago
Created attachment 16919 [details] [diff] [review]
Extract the dom jar before building anything, second iteration.

Comment 22

17 years ago
Hi Ashu,

I've just attached a diff which I believe implements "unjar the w3c dom before
doing anything" functionality without breaking anything.

Can you please review the previous two attachments and if they work, can you
please check them in?

Thanks,

Ed
(Assignee)

Comment 23

17 years ago
Created attachment 17989 [details] [diff] [review]
cvs diff -u of runem_commercial.pl
(Assignee)

Comment 24

17 years ago
Created attachment 18271 [details] [diff] [review]
cvs diff -u for making commercial solaris package use .sh instead of .pl script
(Assignee)

Comment 25

17 years ago
Cloding Bug. All changes required for PR3 are in place and the PR3 branch is
frozen. This bug may be reopened only for extra RTM packaging needs.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 26

17 years ago
Created attachment 19557 [details] [diff] [review]
cvs diff -u for Blackconnect integration. Also added java/external/Makefile.in
(Assignee)

Comment 27

17 years ago
Reopening for RTM

Posted fix to integrate Blackconnect into commercial solaris package
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

17 years ago
Status: REOPENED → ASSIGNED
(Assignee)

Comment 28

16 years ago
Closing Bug. After RTM, everything is in place for Blackwood packaging on 
Solaris
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago16 years ago
Resolution: --- → FIXED
Component: Java APIs to WebShell → Java APIs to WebShell
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.