541297 - "ABORT: Got a regular sample during startup state, expected an end sample instead" with svg:animate

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase (triggers fatal assertion)

This testcase triggers:

###!!! ABORT: Got a regular sample during startup state, expected an end sample instead: 'mElementState != STATE_STARTUP || aEndOnly', file /Users/jruderman/mozilla-central/content/smil/nsSMILTimedElement.cpp, line 376

Other variants trigger:

###!!! ABORT: Negative sample time for active animation: 'mSampleTime >= 0 || !mIsActive', file /Users/jruderman/mozilla-central/content/smil/nsSMILAnimationFunction.cpp, line 255

Comment 1

[Brian Birtles (:birtles)]

I'm not expecting to start working again until 17 May but unless someone wants to look at this before then I'll take this.

Comment 2

[Brian Birtles (:birtles)]

Attachment: patch v1a

Proposed fix for this bug.
I've included the original test case as a crash test. Is this correct? Since it's not so much as crash test as an abort test?

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to comment #2)
> I've included the original test case as a crash test. Is this correct?

Yes, that's correct -- crashtests are the simplest way to regression-test an NS_ABORT_IF_FALSE failure right now.  (The same goes for assertion failures, I think, especially now that bug 472557 has landed.)

Comment 4

[Brian Birtles (:birtles)]

Pushed: http://hg.mozilla.org/mozilla-central/rev/3850fff31141