support loading an additional mozconfig for push-to-try

RESOLVED FIXED

Status

defect
P5
normal
RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: bhearsum, Assigned: lsblakk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [try-server])

Attachments

(3 attachments, 1 obsolete attachment)

As part of the "try as a branch" project we're going to change the sendchange.cgi submission interface to push-to-try on the backend. We'll need a way to have uploaded mozconfigs continue to work. Bsmedberg suggested something like this in the try mozconfigs:
if [ -f $topsrcdir/.mozconfig-extra ]; then
  . $topsrcdir/.mozconfig-extra
fi

Or instead of $topsrcdir, perhaps $(dirname $0)/.mozconfig-extra.
Reporter

Updated

10 years ago
Whiteboard: [try-server]
Reporter

Updated

10 years ago
Blocks: 541365
Reporter

Comment 1

10 years ago
As it turns out, I don't think I'll be doing this...
Assignee: bhearsum → nobody
Running this in the directory with the mozconfigs should alter the in the required fashion.

for i in linux linux-unittest macosx macosx-unittest maemo win32 win32-unittest wince winmo ; do
    cat >> mozconfig-${i} <<EOF
if [ -f \$topsrcdir/mozconfig-extra ] ; then
  . \$topsrcdir/mozconfig-extra
fi
if [ -f \$topsrcdir/mozconfig-extra-$i ] ; then
  . \$topsrcdir/mozconfig-extra-$i
fi
EOF
done
Assignee: nobody → jhford
Attachment #425859 - Flags: review?(anodelman)
Attachment #425859 - Flags: checked-in?
Attachment #425859 - Flags: review?(anodelman) → review+
The script in comment 2 needs to be run against the new mozconfigs which are going to be in the buildbot-configs/mozilla2(-staging)/ instead of buildbot-configs/tryserver(-staging)
Assignee: jhford → nobody
Status: ASSIGNED → NEW
Priority: -- → P5
worked in try-staging (ignoring that my custom mozconfig was incorrect):

/builds/slave/tryserver-linux/build/configure
/builds/slave/tryserver-linux/build/mozconfig-extra-linux: line 1: ac-add-options: command not found
Adding configure options from /builds/slave/tryserver-linux/build/.mozconfig:
Attachment #425859 - Attachment is obsolete: true
Attachment #441104 - Flags: review?(catlee)
Assignee: nobody → lsblakk
Attachment #441104 - Flags: review?(catlee) → review+
Comment on attachment 441104 [details] [diff] [review]
[tested] adds ability to have custom mozconfigs to current tryserver mozconfigs

Looks good for Linux.

You can leave out the codecoverage mozconfig.

You also need mozconfigs for the other platforms, and for production.
Comment on attachment 441104 [details] [diff] [review]
[tested] adds ability to have custom mozconfigs to current tryserver mozconfigs

http://hg.mozilla.org/build/buildbot-configs/rev/6df4a731063f

second patch coming to clean up codecoverage and put in other platforms & production
Attachment #441104 - Flags: checked-in+
Attachment #442141 - Flags: review?(catlee) → review+
Attachment #442142 - Flags: review?(catlee) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.