54142 - + within integer attribute is stripped, should signal end of number

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Jesse Ruderman]

http://www.flightgear.org/Gallery/ has a few images with height=128+0+0.  
Mozilla interprets this as height="12800".

Bug 52019 may be related.

Comment 1

[Jesse Ruderman]

Attachment: test case

Comment 2

[Chris Waterson]

this is prolly nisheeth's area

Comment 3

[Nisheeth Ranjan]

This bug has been marked "future" because the original netscape engineer working
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug, or if it blocks your work in some way
-- please attach your concern to the bug for reconsideration.

Comment 4

[Jesse Ruderman]

possible developer release note for rtm: see bug 52019.

Comment 5

[Hixie (not reading bugmail)]

Reassigning QA Contact for all open and unverified bugs previously under Lorca's
care to Gerardo as per phone conversation this morning.

Comment 6

[bsharma]

qa contact updated.

Comment 7

[Boris Zbarsky [:bzbarsky]]

*** Bug 87638 has been marked as a duplicate of this bug. ***

Comment 8

[Heikki Toivonen (remove -bugzilla when emailing directly)]

SPAM. HTML Element component deprecated, changing component to Layout. See bug
88132 for details.

Comment 9

[Christopher Hoess (gone)]

OK to correct for quirks mode, but we should probably ignore the value for strict.

Comment 10

[Jesse Ruderman]

I don't think we should ignore the value in standards mode.  That would be an 
unnecessary difference between quirks mode (display existing web pages as 
intended by page authors) and standards mode (display standards web pages as 
specifed by standards).

Comment 11

[Boris Zbarsky [:bzbarsky]]

*** Bug 145427 has been marked as a duplicate of this bug. ***

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: Simple, safe, focused fix

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: not-so-safe-but-correct fix

Comment 14

[Boris Zbarsky [:bzbarsky]]

Both of these patches make us work the same as IE5 and NS4 and pretty much the
same as opera.

ccing jag and jst, since the first patch touches jst's code and the second patch
(which I prefer, myself) is jag's code.

Thoughts?

Comment 15

[Robert Milkovits]

Also see bug 119548 (should be marked as a duplicate). It seems that other
browsers (IE 5.5, Netscape 4) support this "+ in an integer attribute", and (to
me) the w3c standards do not seem clear on whether an integer data type means
just [0-9] or whether an integer includes simple math (+-*/).

Comment 16

[Boris Zbarsky [:bzbarsky]]

The other browsers do not do any math.  They just drop the "+" and everything 
following it.  Try doing an image with |width="20+20"| to see that -- IE5, 
Opera, NS4 all render it 20 pixels wide, not 40 pixels.

Comment 17

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 84173 [details] [diff] [review]
not-so-safe-but-correct fix

jag says sr=jag

Comment 18

[Boris Zbarsky [:bzbarsky]]

I'll take this.

Comment 19

[Boris Zbarsky [:bzbarsky]]

And checked in to trunk.

Comment 20

[Boris Zbarsky [:bzbarsky]]

*** Bug 79348 has been marked as a duplicate of this bug. ***