Dehydra copyright notice is obviously wrong

RESOLVED FIXED

Status

Firefox Build System
Source Code Analysis
RESOLVED FIXED
8 years ago
2 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

8 years ago
The only copyright notice is found in README, and it says:
Copyright (C) 1983 Mozilla Corporation

Really ? 1983 ?

Comment 1

8 years ago
What version is this ? The one from Mozilla (NOT from your linux distribution !) only says :

For information about installing, running and configuring Firefox
including a list of known issues and troubleshooting information,
refer to: http://getfirefox.com/releases/
(Assignee)

Comment 2

8 years ago
Let's make the subject more explicit, then.
Summary: Copyright notice is obviously wrong → Dehydra copyright notice is obviously wrong

Comment 3

8 years ago
Let's make it easy to find what you're talking about:

http://hg.mozilla.org/rewriting-and-analysis/dehydra/annotate/d039748e7775/README
(Assignee)

Comment 4

8 years ago
I could write a patch, but I'd need the proper copyright information for that... Taras ?

Comment 5

8 years ago
(In reply to comment #4)
> I could write a patch, but I'd need the proper copyright information for
> that... Taras ?

It should be 2007-2008. A patch would be appreciated.
(Assignee)

Comment 6

8 years ago
Should that be copyrighted to MoCo or yourself ? While at it, should I add the GPL boilerplate in every file (or at least *.{c,h,js}) ?

Comment 7

8 years ago
(In reply to comment #6)
> Should that be copyrighted to MoCo or yourself ? While at it, should I add the
> GPL boilerplate in every file (or at least *.{c,h,js}) ?

MoCo; should add these to every file.
Copyright should cite "The Mozilla Foundation", per Gerv.

/be
(Assignee)

Comment 9

8 years ago
Created attachment 437251 [details] [diff] [review]
Patch

This adds a GPL boilerplate in any file that didn't already have licensing information. FWIW, libs/unstable/BigInt.js already had a GPL header, and a copyright to Masanao Izumo <iz@onicos.co.jp>. I do hope none of the other files were taken from somewhere else, while lacking copyright information...

Note I haven't touched to the files in test/, I wasn't sure what to do with these.
Assignee: tglek → mh+mozilla
Attachment #437251 - Flags: review?(tglek)
(Assignee)

Comment 10

8 years ago
Comment on attachment 437251 [details] [diff] [review]
Patch

Gerv should probably review this, I guess.
Attachment #437251 - Flags: review?(gerv)
Comment on attachment 437251 [details] [diff] [review]
Patch

This stuff is closely tied to GCC, which is also GPLv2+, right? If so, r=gerv.

Gerv
Attachment #437251 - Flags: review?(gerv) → review+

Comment 12

8 years ago
Comment on attachment 437251 [details] [diff] [review]
Patch

Why is the copyright date 2007-2008?
(Assignee)

Comment 13

8 years ago
(In reply to comment #12)
> (From update of attachment 437251 [details] [diff] [review])
> Why is the copyright date 2007-2008?

Hum... per comment 5 ?

Comment 14

8 years ago
(In reply to comment #13)
> (In reply to comment #12)
> > (From update of attachment 437251 [details] [diff] [review] [details])
> > Why is the copyright date 2007-2008?
> 
> Hum... per comment 5 ?

I must've been living in the past. I'll r+ a -2010 patch. Do you have checkin rights?
(Assignee)

Comment 15

8 years ago
Created attachment 437347 [details] [diff] [review]
Patch v2

Same, with -2010. (No, I don't have checkin rights (yet))
Attachment #437251 - Attachment is obsolete: true
Attachment #437251 - Flags: review?(tglek)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 17

8 years ago
Created attachment 437534 [details] [diff] [review]
Brown paper bag fix

Necessary (brown paper bag) fix for Makefile.in breakage
Attachment #437534 - Flags: review?(tglek)
(Assignee)

Updated

8 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

8 years ago
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED

Updated

2 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.