Closed Bug 541755 Opened 14 years ago Closed 14 years ago

Add ability to remove notification bar without triggering animation.

Categories

(Toolkit :: UI Widgets, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a2

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v.1 (obsolete) — Splinter Review
The plugin-crashed UI I'm adding in bug 538910 needs to be able to remove a previously added notification bar without triggering an animation. This is for the case when there are multiple plugins on a page, and the first one we see a PluginCrashed event for results in a notificationbar (because it's too small to show the in-content UI), but then we find another plugin on the page big enough to show the in-content UI (so we want to remove the notification bar we just added).

With this patch, the removal for the above case is completely invisible (ie, no sign there's something going on with a notification bar at all).
Attachment #423201 - Flags: review?(enndeakin)
Comment on attachment 423201 [details] [diff] [review]
Patch v.1

>diff --git a/toolkit/content/widgets/notification.xml b/toolkit/content/widgets/notification.xml

>-              this.removeCurrentNotification();
>+              this.removeCurrentNotification(true);

This is meant to be removeCurrentNotification(aSkipAnimation) presumably...
Oops, yes.
Comment on attachment 423201 [details] [diff] [review]
Patch v.1

Looks ok with Gavin's comment taken into account.
Attachment #423201 - Flags: review?(enndeakin) → review+
Attached patch Patch v.2Splinter Review
Updated with review comment.
Attachment #423201 - Attachment is obsolete: true
Pushed http://hg.mozilla.org/mozilla-central/rev/70257fee51df
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: