Last Comment Bug 541934 - Address book sort in reverse order with first click of column header
: Address book sort in reverse order with first click of column header
Status: RESOLVED FIXED
: polish
Product: MailNews Core
Classification: Components
Component: Address Book (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Thunderbird 17.0
Assigned To: :aceman
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-25 03:42 PST by Trevor Morgan
Modified: 2012-08-01 13:41 PDT (History)
5 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.47 KB, patch)
2012-07-22 08:03 PDT, :aceman
mconley: review+
iann_bugzilla: review+
mconley: ui‑review+
Details | Diff | Splinter Review

Description Trevor Morgan 2010-01-25 03:42:48 PST
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.5) Gecko/20091204 Lightning/1.0b1 Thunderbird/3.0

When clicking on a column header in the address book, the first click sorts by reverse alphabetic or high-to-low.  The second click sorts low-to-high.

Reproducible: Always

Steps to Reproduce:
Click on a column header in the address book (of an unsorted column).
Actual Results:  
The column is sorted Z..A or 9..0
A second click is needed to sort forwards

Expected Results:  
The column should be sorted 0..9 or A..Z on the first click.

The column sorting works as expected in the mail window - it's just the address book that's wrong.
Comment 1 :aceman 2012-07-22 08:03:12 PDT
Created attachment 644760 [details] [diff] [review]
patch

This seems to do it.
Comment 2 :aceman 2012-07-22 08:04:20 PDT
Comment on attachment 644760 [details] [diff] [review]
patch

The fix is in a /mailnews file so could affect Seamonkey.
Comment 3 Ian Neal 2012-07-22 14:19:14 PDT
Comment on attachment 644760 [details] [diff] [review]
patch

r=me
Comment 4 Mike Conley (:mconley) 2012-08-01 12:38:34 PDT
Comment on attachment 644760 [details] [diff] [review]
patch

Review of attachment 644760 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, beautiful.  Yes, this feels much better.  Thanks aceman.
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-08-01 13:41:54 PDT
https://hg.mozilla.org/comm-central/rev/5ab0c167661f

Note You need to log in before you can comment on or make changes to this bug.