Closed Bug 541934 Opened 10 years ago Closed 7 years ago

Address book sort in reverse order with first click of column header

Categories

(MailNews Core :: Address Book, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 17.0

People

(Reporter: trevmrgn+bug, Assigned: aceman)

Details

(Keywords: polish)

Attachments

(1 file)

1.47 KB, patch
mconley
: review+
iann_bugzilla
: review+
mconley
: ui-review+
Details | Diff | Splinter Review
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.5) Gecko/20091204 Lightning/1.0b1 Thunderbird/3.0

When clicking on a column header in the address book, the first click sorts by reverse alphabetic or high-to-low.  The second click sorts low-to-high.

Reproducible: Always

Steps to Reproduce:
Click on a column header in the address book (of an unsorted column).
Actual Results:  
The column is sorted Z..A or 9..0
A second click is needed to sort forwards

Expected Results:  
The column should be sorted 0..9 or A..Z on the first click.

The column sorting works as expected in the mail window - it's just the address book that's wrong.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → ASSIGNED
Keywords: polish
Product: Thunderbird → MailNews Core
Version: unspecified → Trunk
Attached patch patchSplinter Review
This seems to do it.
Assignee: nobody → acelists
Attachment #644760 - Flags: ui-review?(mconley)
Attachment #644760 - Flags: review?(mconley)
Comment on attachment 644760 [details] [diff] [review]
patch

The fix is in a /mailnews file so could affect Seamonkey.
Attachment #644760 - Flags: review?(iann_bugzilla)
Comment on attachment 644760 [details] [diff] [review]
patch

r=me
Attachment #644760 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 644760 [details] [diff] [review]
patch

Review of attachment 644760 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, beautiful.  Yes, this feels much better.  Thanks aceman.
Attachment #644760 - Flags: ui-review?(mconley)
Attachment #644760 - Flags: ui-review+
Attachment #644760 - Flags: review?(mconley)
Attachment #644760 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/5ab0c167661f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.