[buildbot] Add additional branch to the buildset

VERIFIED FIXED

Status

defect
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: brbaker, Assigned: brbaker)

Tracking

Details

Attachments

(3 attachments, 3 obsolete attachments)

Assignee

Description

10 years ago
We will need to add an additional branch to the build during a lock down period of a release cycle. This branch will need to be a high priority build and run through all of the same builders that tamarin-redux changes build on.

Will need to modify the:
- buildbot configuration
- announce.html (top of the waterfall view)
- gatekeeper watcher script
- mercurial hooks that trigger build requests
Assignee

Comment 1

10 years ago
- move the branch buildbot definitions into separate files so they can be easily turned on/off in the master.cfg
- add argo section to the announce page (top of the waterfall)
Attachment #423341 - Flags: review?(cpeyer)
Assignee

Comment 2

10 years ago
Attachment #423344 - Flags: review?(cpeyer)
Assignee

Comment 3

10 years ago
Posted patch scheduler (obsolete) — Splinter Review
Attachment #423373 - Flags: review?
Assignee

Updated

10 years ago
Attachment #423373 - Flags: review? → review?(cpeyer)
Assignee

Comment 4

10 years ago
Comment on attachment 423373 [details] [diff] [review]
scheduler

Scheduler for deep and performance phases. This will be triggered via a build request sent via buildbot sendchange. The change request will contain which buildslaves completed the first phase of the build and therefore which builders should build the phase 2. The relationship between the builders is defined in the "builderDependencies". This is the same as the BuilderDependent scheduler that we use for smoke and test.
Assignee

Comment 5

10 years ago
Comment on attachment 423373 [details] [diff] [review]
scheduler

Just noticed that the call to  Scheduler.__init__() was not 100% correct, contained default param values from previous def, tweaked locally

Updated

10 years ago
Attachment #423341 - Flags: review?(cpeyer) → review+

Updated

10 years ago
Attachment #423344 - Flags: review?(cpeyer) → review+

Updated

10 years ago
Attachment #423373 - Flags: review?(cpeyer) → review+
Assignee

Comment 6

10 years ago
Comment on attachment 423344 [details] [diff] [review]
change request scripts

scripts are being moved into a QE shared repo as they are used by other projects
Attachment #423344 - Attachment is obsolete: true
Assignee

Comment 7

10 years ago
Comment on attachment 423341 [details] [diff] [review]
buildbot changes

Patch pushed, 3637:2d759267de5d
Attachment #423341 - Attachment is obsolete: true
Assignee

Updated

10 years ago
Attachment #423344 - Attachment is obsolete: false
Assignee

Updated

10 years ago
Attachment #423341 - Attachment is obsolete: false
Assignee

Comment 8

10 years ago
Posted patch Rev2 patch (obsolete) — Splinter Review
- modify environment script to only set the /branch/ if it is not already set
- modify buildbot steps to pass in the /branch/ variable: tamarin-redux|tamairn-argo|sandbox
- change the solaris deep buildslave to get the builds from internal server
- Change how deep and performance runs are triggered. Now has an external queue that controls how/when builds are triggered. This matches how the phase1 builders work (compile,smoke,test)
- Add deep and performance for the argo branch
- remove winmo-frunit run in the deep builder
Attachment #423373 - Attachment is obsolete: true
Attachment #424768 - Flags: review?(cpeyer)
Assignee

Comment 9

10 years ago
Posted patch Rev3 patchSplinter Review
- add back commented out steps for testing
- modify environment script to only set the /branch/ if it is not already set
- modify buildbot steps to pass in the /branch/ variable:
tamarin-redux|tamairn-argo|sandbox
- change the solaris deep buildslave to get the builds from internal server
- Change how deep and performance runs are triggered. Now has an external queue
that controls how/when builds are triggered. This matches how the phase1
builders work (compile,smoke,test)
- Add deep and performance for the argo branch
- remove winmo-frunit run in the deep builder
Attachment #424768 - Attachment is obsolete: true
Attachment #424773 - Flags: review?(cpeyer)
Attachment #424768 - Flags: review?(cpeyer)

Updated

10 years ago
Attachment #424773 - Flags: review?(cpeyer) → review+
Assignee

Comment 10

10 years ago
Pushed changes for:
- modify environment script to only set the /branch/ if it is not already set
- change the solaris deep buildslave to get the builds from internal server
 as 
tamarin-redux-argo: 3648:a19ef719b265
tamarin-redux: changeset: 3714:a19ef719b265
Assignee

Comment 11

10 years ago
Pushed the remaining items into tamarin-redux as 3717:26f65a0348c9

- modify buildbot steps to pass in the /branch/ environment variable: tamarin-redux|tamairn-argo|sandbox
- Change how deep and performance runs are triggered. Now has an external queue
that controls how/when builds are triggered. This matches how the phase1
builders work (compile,smoke,test)
- Add deep and performance for the argo branch
- remove winmo-frunit run in the deep builder

Comment 12

10 years ago
Talking with lars today realized that we should be pulling from FR-argo instead of FRR when building FR-argo.
Attachment #425103 - Flags: review?(brbaker)
Assignee

Updated

10 years ago
Attachment #425103 - Attachment is obsolete: true
Attachment #425103 - Flags: review?(brbaker)
Assignee

Updated

10 years ago
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Status: RESOLVED → VERIFIED
Assignee

Comment 13

10 years ago
There was a bug in how changes were being triggered for deep and performance after a successfull phase 1 build. 

Patch pushed to TR 3781:56602bdd3d28
Assignee

Comment 14

9 years ago
Pushed another fix to the branch name used by the redux performance scheduler, should have been "%branch-performance" not "%branch-perf"

tr changeset 4511:8841b2bf8892
You need to log in before you can comment on or make changes to this bug.