541959 - Extension's preferences window behaves incorrectly after "browser.preferences.instantApply" change

Status: NEW

(Toolkit :: Preferences, defect)

Description

[Zbynek Michl]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.1.6) Gecko/20091216 Iceweasel/3.5.6 (like Firefox/3.5.6; Debian-3.5.6-1)
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.1.6) Gecko/20091216 Iceweasel/3.5.6 (like Firefox/3.5.6; Debian-3.5.6-1)

My extension has a simple preferences window with checkbox as follows:

<prefwindow ...>
  <prefpane ...>
    <preferences>
      <preference id="flag" name="extensions.name.flag" type="bool"/>
    </preferences>
    <checkbox preference="flag" label="flag"/>
  </prefpane>
</prefwindow>

1. When "browser.preferences.instantApply" is set to true, then I open pref window and click checkbox, "extensions.name.flag" changes its value immediately. -> It is correct.
When I change "browser.preferences.instantApply" to false and then click checkbox again (pref window is still opened and has not been reopened), "extensions.name.flag" changes its value immediately again. -> It is correct again (ok, I changed instantApply, but window should has the same behaviour until is reopened).

But opposite case:

2. When "browser.preferences.instantApply" is set to false, then I open pref window and click checkbox, "extensions.name.flag" does not change its value immediately. -> It is correct.
When I change "browser.preferences.instantApply" to true and then click checkbox again (pref windows is still opened and has not been reopened), "extensions.name.flag" changes its value immediately. -> It should not do it until ondialogaccept is called (window should has the same behaviour until is reopened).


Reproducible: Always

Steps to Reproduce:
1. Set "browser.preferences.instantApply" to false in "about:config".
2. Open extension's pref window, "instantApply" is false, thus window contains OK and Cancel buttons.
3. Change "instantApply" to true in "about:config" (while pref window is still opened).

Actual Results:  
Preferences in that window immediately change its behaviour according
to "instantApply" change.


Expected Results:  
Preferences in that window should not immediately change its behaviour according
to "instantApply" change, because window still has OK and Cancel buttons, so the same behaviour should be preserved until pref window is reopened.


It is Firefox 3.5 and higher issue, version 3.0 handles above situation correctly.

Comment 1

[Kevin Brosnan]

Discussed in d.a.Firefox. http://groups.google.com/group/mozilla.dev.apps.firefox/browse_thread/thread/4077522fa87f89fa/02f8065678882f6c

Comment 2

[Mike Connor [:mconnor]]

pretty sure this was broken by 451025, we really need to make that property get set on startup, but that's not how the code appears to handle it.