If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

sydney_audio_mac.c bustage on 1.9.1 branch

VERIFIED WORKSFORME

Status

()

Core
Audio/Video
VERIFIED WORKSFORME
8 years ago
7 years ago

People

(Reporter: Josh Aas, Unassigned)

Tracking

1.9.1 Branch
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c: In function ‘sa_stream_open’:
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:182: error: ‘ComponentDescription’ undeclared (first use in this function)
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:182: error: (Each undeclared identifier is reported only once
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:182: error: for each function it appears in.)
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:182: error: expected ‘;’ before ‘desc’
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:183: error: ‘desc’ undeclared (first use in this function)
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:189: error: ‘Component’ undeclared (first use in this function)
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:189: error: expected ‘;’ before ‘comp’
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:190: error: ‘comp’ undeclared (first use in this function)
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:194: warning: implicit declaration of function ‘OpenAComponent’
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c: In function ‘sa_stream_destroy’:
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:283: warning: implicit declaration of function ‘CloseComponent’
(Reporter)

Comment 1

8 years ago
Created attachment 423377 [details] [diff] [review]
fix v1.0
(Reporter)

Updated

8 years ago
Attachment #423377 - Flags: review?(chris.double)

Updated

8 years ago
Attachment #423377 - Flags: review?(chris.double)

Comment 2

8 years ago
Comment on attachment 423377 [details] [diff] [review]
fix v1.0

Please add to README_MOZILLA with the details of this bug, and include a patch file that can be applied in update.sh.

For the review use Matthew Gregan (kinetik@flim.org) - he's the maintainer of the libsydneyaudio library now (If I understood FOMS correctly).

Since this fix is already in trunk maybe it's a matter of copying the trunk changes?
Given this is already on trunk, I'm fine with it as long as it's applied the same way it is on trunk (with the patch and readme updates doublec mentioned).
Presumably we don't need this.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WORKSFORME
I assume from comment 4 that you mean "this isn't a bug on the branches" -- marking verified.  If this IS a bug on the branches which will not be addressed, this should probably be WONTFIX instead.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.