configure.in does the wrong thing with darwin and -rpath-link

RESOLVED FIXED in mozilla1.9.3a2

Status

defect
RESOLVED FIXED
10 years ago
Last year

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
mozilla1.9.3a2
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

And in particular tries to pass it to the mac ld when cross-compiling with toolwhip.

http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#894
http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#1504

<ted> we override that for darwin hosts
<ted> but not for darwin targets
The main configure has the same issue.
Summary: js/src/configure.in does the wrong thing with darwin and -rpath-link → configure.in does the wrong thing with darwin and -rpath-link
Attachment #423384 - Flags: review?(ted.mielczarek)
Attachment #423384 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 423384 [details] [diff] [review]
This seems to do the trick

Can you remove the line that sets it in the *darwin* host check as well? (mentioned in comment 0)
Assignee: nobody → bzbarsky
Pushed http://hg.mozilla.org/mozilla-central/rev/8bb89e41032a with the change from comment 3.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #427280 - Flags: review?(kairo)

Updated

10 years ago
Attachment #427280 - Flags: review?(kairo) → review+
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a2

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.