542033 - configure.in does the wrong thing with darwin and -rpath-link

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Boris Zbarsky [:bzbarsky]]

And in particular tries to pass it to the mac ld when cross-compiling with toolwhip.

http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#894
http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#1504

<ted> we override that for darwin hosts
<ted> but not for darwin targets

Comment 1

[Boris Zbarsky [:bzbarsky]]

The main configure has the same issue.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: This seems to do the trick

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 423384 [details] [diff] [review]
This seems to do the trick

Can you remove the line that sets it in the *darwin* host check as well? (mentioned in comment 0)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/8bb89e41032a with the change from comment 3.

Comment 5

[Justin Wood (:Callek)]

Attachment: comm-central part

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 427280 [details] [diff] [review]
comm-central part

Pushed as: http://hg.mozilla.org/comm-central/rev/64872055de2a