54205 - Netlanski movie (netling) hangs when "getNetText" button is pushed in Netscape 6 (Mozilla) [@ IML32.dll]

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[kcunningham]

From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 5.0; Mac_PowerPC)
BuildID:    2000081721

Netlanski movie (netling) hangs when "getNetText" button is pushed in 
Netscape 6 (Mozilla)

Reproducible: Always
Steps to Reproduce:
1. Install Netscape 6 (mozilla) on WIN 98 or WIN ME
2. Install SW8.5r125 FullNoPing
3. Goto thebox/netlanski
4. Goto the movie "netling" under Netlingo
5 Select oblique.cgi
6. Press getNetText



Expected: netDone field should =1

Actual Results:  		Results: Movie hangs and does not reproduce the result 
of "1" in the netDone field. 					

Expected Results:  					Expected: netDone field should =1		

			Mozilla bug ... getnettext generates a NPN_GetUrlNotify() request to the 
browser. This is working for most urls (checked those ending in .txt, .dcr, 
.html), that is, the browser will reply with NPP_NewStream() almost 
immediately, but for cgi scripts (url's with extension .cgi), mozilla is giving 
us nothing (not even NPP_UrlNotify() with an error).

Comment 1

[ekrock's old account (dead)]

Adding shockwave,crash,nsbeta3,rtm keywords. Marking confirmed per previous 
comments. Setting P1 as this is a high profile partner (Macromedia), and high 
profile backward compatibility (Shockwave plug-in backward compatibility and web 
pages on the popular macromedia.com web site, which has recently boomed in 
membership according to the New York Times), and an always-reproducible crasher. 

Comment 2

[ekrock's old account (dead)]

Adding more info from email correspondence: 

Kelly, 

[Shockwave bug] 62592 - Netlanski movie (netling) hangs when "getNetText" button 
is pushed in Netscape 6 (Mozilla) is a Mozilla bug, so I've NMI'ed it to you. 
Here's my comment in the bugbase : 

9/26/2000 grandma : I'm not seeing a hang (although there's a busy cursor, you 
can click on netabort() and the operation stops), but neither am I seeing the 
operation go through (winnt4.0, mozilla 9/14/2000, sw8.5r125). This is a Mozilla 
bug ... getnettext generates a NPN_GetUrlNotify() request to the browser. This 
is working for most urls (checked those ending in .txt, .dcr, .html), that is, 
the browser will reply with NPP_NewStream() almost immediately, but for cgi 
scripts (url's with extension .cgi), mozilla is giving us nothing (not even 
NPP_UrlNotify() with an error). 

Said another way, I believe invoking NPN_GetUrlNotify() with an url with 
extension ".cgi" will return NPERR_NO_ERROR, but no stream is spawned from the 
request. 

Peter 

At 10:31 AM 9/26/00 -0700, Kelly Cunningham wrote: 

Well I got another one in there our 62214 which is 54186 in Mozilla bugbase:
Netscape 6pr2 on mac crashes with SW8.5 when going from a streaming netlanski
.dcr to another .dcr (Not in SW8.0). 

They will need access to SW8.5 since I have not seen the crash in SW8.0. 

Kelly 

At 9:08 AM -0700 9/26/00, Alan Isaacs wrote: 

Peter, I've assigned 62592 to you -- netlingo failures in Netscape 6 Windows. 
(Eric, netlingo enables Shockwave to connect to the net, as by bringing in text 
or media from a url.) 

Thanks, 
Alan

Comment 3

[Braden]

Legacy plugin issue. Adding 4xp.

Comment 4

[karnaze (gone)]

Reassigning to Marc. Adding rtm+.

Comment 5

[Phil Peterson]

PDT marking [rtm need info] since this bug doesn't have a patch or reviewers 
yet.

Comment 6

[Marc Attinasi]

Over to Peter to look at. Thanks, Peter.

Comment 7

[Peter Lubczynski]

Instead of hanging, I'm crashing in IML32.DLL which is a Macromedia DLL (in NT). 
I'm not getting a very helpful stack trace. Perhaps Rational Purify will help 
but I'm having great trouble getting a key for version 6.5 from Rational.

Reporter: I'm a bit confused about the orriginal bug report. It says I should be 
using Shockwave 8.5 r125 FullNoPing. Looking at the Macromedia Flash/Shockwave 
download page, it says the current version is 8.0. I am using 8.0 r196. Should I 
be using "8.5 r125 FullNoPing" and if so, where can I get it. None of the links 
on the bottom of the netlanski page seem to work.

Thanks.

Comment 8

[Meredith Tomlin]

From Meredith Tomlin - Kelly Cunningham retested this issue on 10/5/00 and 
found that Netlanski movie (netling) hangs when "getNetText" button is pushed 
in Netscape 6 (Mozilla) - Looks like now in NS6pr3 you get error 4836.

Comment 9

[shrirang khanzode]

With the latest shockwave plugin available at macromedia site (8.0r196), I do 
not hang but instead CRASH on this test using today's commercial build on 
windows branch (2000100908). We do not have the 8.5r125 to test this on.
Stack trace from cyclone:

 Call Stack:    (Signature = IML32.dll + 0x13da3 (0x69013da3) 9a319e11) 
     
   IML32.dll + 0x13da3 (0x69013da3) 
                                     

Comment 10

[Peter Lubczynski]

Attachment: trivial patch to ensure MIME type gets passed

Comment 11

[Peter Lubczynski]

With Peter Grandmaison from Macromedia help, I found that sometimes we were 
passing null as the MIME type to the plugin. This patch ensures that we set the 
MIME type. 

Adding review to keywords to get a review. 

Comment 12

[Peter Lubczynski]

Oh, and this patch also prevents us from crashing in both Shockwave 8.0 and 8.5. 

Comment 13

[Simon Fraser [no longer active]]

The patch appears to leak aContentType, no?

Comment 14

[Peter Lubczynski]

Added

nsCRT::free(aContentType) 

due to leak. Is that good for an r=

Comment 15

[Peter Lubczynski]

Attachment: revised patch which doesn't leak

Comment 16

[Peter Lubczynski]

Marking rtm+ per karnaze

Comment 17

[ekrock's old account (dead)]

PDT: Crasher for high-profile plug-in partner (Macromedia Shockwave). Identified 
by partner (Macromedia) as one of their highest-priority outstanding issues for 
Shockwave support in Moz/N6. Fix is low risk: we're simply passing a MIME type 
always (as we should) instead of sometimes passing it and sometimes passing 
null. Please call me if you're thinking of minusing this and I'll rope in 
engineering to present why this should be accepted for RTM. Thanks!

Comment 18

[Simon Fraser [no longer active]]

nsCRT::free(aContentType); is not null-safe (it calls down into PL_strfree()), so 
you need

if (aContentType)
  nsCRT::free(aContentType)

With that fix, r=sfraser

Comment 19

[Jim Roskind]

Please put exact patch (with Simon's suggestion) in bug, and get a super-review
of the final patch.  There is always a chance that this correction will trigger
something else in the mind of the super-reviewer....
Marking rtm need info.

Comment 20

[Peter Lubczynski]

Attachment: complete patch per JAR's request

Comment 21

[Peter Lubczynski]

...clearning [rtm need info] and review
...anding r=sfraser and a=buster (per e-mail)

Comment 22

[buster]

re-affirming my a=buster with the final patch (10/13/00 11:52.)  Nice catch, Simon!

Comment 23

[Peter Lubczynski]

sorry for the SPAM....

oops, removed rtm+, adding it back it so it'll show up on the PDT radar for 
approval today

Comment 24

[Phil Peterson]

rtm++

Comment 25

[Peter Lubczynski]

Just checked into the branch. 

Going through some shockwave talkback reports, looks like this fix may need to 
be applied in other parts of this class. For example, see the stack trace in 
bug 56896. I'll continue to investigate but this "getNetText" bug should be 
fixed [in the branch].

Comment 26

[Jay Patel [:jay]]

adding topcrash keyword and [@ IML32.dll] for tracking...this has been on the 
topcrash list lately.

Comment 27

[Peter Lubczynski]

I just checked this into the trunk. marking FIXED

Comment 28

[shrirang khanzode]

I verified this on the branch as well as trunk build for today on windows 
20001018 with SW 8.5 , the movie loads fine and does not hang doing the steps 
mentioned initially. marknig this VERIFIED.

Comment 29

[kcunningham]

This movie no longer hangs or crashes, it's true, but still does not return 

proper value for getNetText. The result is error" 4836". I think this should 

remain open under more investigation. Or perhaps I can write another 

bug with the actual current improper behavior?

Comment 30

[kcunningham]

This movie no longer hangs or crashes, it's true, but still does not return 


proper value for getNetText. The result is error" 4836". I think this should 


remain open under more investigation. Or perhaps I can write another 


bug with the actual current improper behavior?

Comment 31

[ekrock's old account (dead)]

In this case, since it's now a distinct problem from the original (and we don't
want to get tangle up in all the keywords, tagging, etc. involved with this
one), the best thing to do is to open a new bug report. I've done it for you:
bug 59571, "netlanski movie (netling) returns incorrect value for getNextText,
error 4836". Kelly, could you please fill in the details in that bug report? Thanks!

Closing this one again.

Comment 32

[shrirang khanzode]

Marking VERIFIED.

Comment 33

[Meredith Tomlin]

Peter Grandmaison sent an email to Peter L with the following information on 
12/1:

Anyways, I can unfortunately reproduce the netlingo bug (error code 4836 comes 
up instead of OK) ... however, I spent an hour in the debugger, and I know why 
this doesn't work !

The cgi stream is of unknown length, so in NPP_NewStream() Netscape 6 is 
passing in a stream length of 0xffffffff, wherease Netscape 4.7 (and IE) pass 
in a stream length of 0x00000000. I made a test build which replaces 0xffffffff 
with 0 and the movie works fine.

This solution would presumably fix other streaming bugs.

Comment 34

[Peter Lubczynski]

Closing this one again as bug 59571 deals with the incorrect return code while 
this one deals with a "hang"

Comment 35

[shrirang khanzode]

marking this VERIFIED again.

Comment 36

[Meredith Tomlin]

Tested and verified by Macromedia QA and Peter Grandmaison on 12/12.