542165 - folderPane.js needs an s/aGenerator/aMode/

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Bryan Clark (DevTools PM) [:clarkbw]]

We've got a slight variable error at line 254
http://mxr.mozilla.org/comm-central/source/mail/base/content/folderPane.js#254

That arrived with this change
http://hg.mozilla.org/comm-central/diff/20c2d9e8e9b4/mail/base/content/folderPane.js#l1.121

I figured a patch would be a little too trivial.

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: fixes the typo

This should be an easy, almost like it's your birthday! :)

Comment 2

[David :Bienvenu]

Comment on attachment 424699 [details] [diff] [review]
fixes the typo

oopsie. 

I should have said birthday (observed) since the all hands interfered with my taking a birthday day closer to my birthday :-) but I appreciate the thought.

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

can i do this without a unit test these days?

Comment 4

[Rain [:rain1] (inactive)]

I doubt it, but I promise to write one as soon as I'm free again. :)

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/87a0aa80097c

(In reply to comment #4)
> I doubt it, but I promise to write one as soon as I'm free again. :)

Setting in-testsuite? ;-)


Do we need this on 3.0.x? If so I'll need to know what was actually broken and what it'll fix.

Comment 6

[Rain [:rain1] (inactive)]

(In reply to comment #5)
> Do we need this on 3.0.x?

No.

Comment 7

[Rain [:rain1] (inactive)]

Attachment: test

I've also moved the smart folder tests into the new directory.

Comment 8

[Rain [:rain1] (inactive)]

Attachment: test v1.01

Oops, forgot to subclass IFolderTreeMode.

Comment 9

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/49dac4a95a26