folderPane.js needs an s/aGenerator/aMode/

RESOLVED FIXED in Thunderbird 3.1b1

Status

Thunderbird
Folder and Message Lists
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: clarkbw, Assigned: clarkbw)

Tracking

Trunk
Thunderbird 3.1b1
Bug Flags:
in-testsuite +

Thunderbird Tracking Flags

(thunderbird3.1 beta1-fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

We've got a slight variable error at line 254
http://mxr.mozilla.org/comm-central/source/mail/base/content/folderPane.js#254

That arrived with this change
http://hg.mozilla.org/comm-central/diff/20c2d9e8e9b4/mail/base/content/folderPane.js#l1.121

I figured a patch would be a little too trivial.
(Assignee)

Comment 1

8 years ago
Created attachment 424699 [details] [diff] [review]
fixes the typo

This should be an easy, almost like it's your birthday! :)
Assignee: nobody → clarkbw
Status: NEW → ASSIGNED
Attachment #424699 - Flags: review?(bienvenu)

Updated

8 years ago
Attachment #424699 - Flags: review?(bienvenu) → review+

Comment 2

8 years ago
Comment on attachment 424699 [details] [diff] [review]
fixes the typo

oopsie. 

I should have said birthday (observed) since the all hands interfered with my taking a birthday day closer to my birthday :-) but I appreciate the thought.
(Assignee)

Comment 3

8 years ago
can i do this without a unit test these days?
Keywords: checkin-needed
I doubt it, but I promise to write one as soon as I'm free again. :)
Checked in: http://hg.mozilla.org/comm-central/rev/87a0aa80097c

(In reply to comment #4)
> I doubt it, but I promise to write one as soon as I'm free again. :)

Setting in-testsuite? ;-)


Do we need this on 3.0.x? If so I'll need to know what was actually broken and what it'll fix.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
status-thunderbird3.1: --- → beta1-fixed
Flags: in-testsuite?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b1
(In reply to comment #5)
> Do we need this on 3.0.x?

No.
Created attachment 434522 [details] [diff] [review]
test

I've also moved the smart folder tests into the new directory.
Attachment #434522 - Flags: review?(bienvenu)
Created attachment 434537 [details] [diff] [review]
test v1.01

Oops, forgot to subclass IFolderTreeMode.
Attachment #434522 - Attachment is obsolete: true
Attachment #434537 - Flags: review?(bienvenu)
Attachment #434522 - Flags: review?(bienvenu)

Updated

8 years ago
Attachment #434537 - Flags: review?(bienvenu) → review+
You need to log in before you can comment on or make changes to this bug.