542239 - Accept pronouns everywhere in query.cgi

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[Gervase Markham [:gerv]]

Unless I'm very much mistaken, this should return all open bugs assigned to the user doing the search:
https://bugzilla.mozilla.org/buglist.cgi?emailassigned_to1=1;query_format=advanced;email1=%25user%25;resolution=---;emailtype1=exact

But on b.m.o. (running 3.4), it says:
"The name %user% is not a valid username. Either you misspelled it, or the person has not registered for a Bugzilla account."

Seems like this is broken all the way back to Bugzilla 3.0:
https://landfill.bugzilla.org/bugzilla-3.0-branch/buglist.cgi?emailassigned_to1=1;query_format=advanced;email1=%25user%25;resolution=---;emailtype1=exact

Gerv

Comment 1

[Frédéric Buclin]

No, pronouns are only used in boolean charts so far. Morphing the bug to reflect what you ask for.

Comment 2

[Max Kanat-Alexander]

For the most part, I suspect that this has already been fixed on HEAD by the refactoring. However, it's not completely done yet.

Comment 4

[Max Kanat-Alexander]

This is actually likely something that will be done as part of finishing up the Search refactoring.

Comment 5

[Frédéric Buclin]

We are going to branch for Bugzilla 4.4 next week and this bug is either too invasive to be accepted for 4.4 at this point or shows no recent activity. The target milestone is reset and will be set again *only* when a patch is attached and approved.

I ask the assignee to reassign the bug to the default assignee if you don't plan to work on this bug in the near future, to make it clearer which bugs should be fixed by someone else.

Comment 7

[Albert Ting]

Attachment: bug-544239-user-pronoun

With this patch, I was able to use the %user% pronoun for the example in original description.  Seems like a rather simple fix, am I missing something?

Comment 8

[David Lawrence [:dkl]]

Comment on attachment 8743053 [details] [diff] [review]
bug-544239-user-pronoun

Review of attachment 8743053 [details] [diff] [review]:
-----------------------------------------------------------------

This does in fact fix the 'is' search type. Will commit with my small change applied. r=dkl

::: Bugzilla/Search.pm~
@@ +1742,3 @@
>          my $email = trim($params->{"email$id"});
>          next if !$email;
>          my $type = $params->{"emailtype$id"} || 'anyexact';

I would also change this to be:

 my $type = $params->{"emailtype$id"} || 'equals';

Comment 9

[David Lawrence [:dkl]]

To ssh://[e-mail]/bugzilla/bugzilla.git
   ab5ec7e..e2b1136  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   a868b88..ea0c502  5.0 -> 5.0