542245 - test_bug368972.html failing: "Plugin element [*] had an incorrect [width|height]"

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I haven't seen this on tinderbox, but it's easily reproducible for me locally on e10s latest

  $ cd $objdir/_test/testing/mochitest
  $ python runtests.py --test-path=content/base/test/test_bug368972.html

I get

Passed: 56
Failed: 10
Todo: 0
passed | Plugin element embed1 did not exist
failed | Plugin element embed1 had an incorrect width - got "auto", expected "240px"
failed | Plugin element embed1 had an incorrect height - got "auto", expected "200px"
passed | Plugin element embed2 did not exist
passed | Plugin element embed2 had an incorrect width
passed | Plugin element embed2 had an incorrect height
passed | Plugin element embed3 did not exist
passed | Plugin element embed3 had an incorrect width
passed | Plugin element embed3 had an incorrect height
passed | Plugin element embed4 did not exist
failed | Plugin element embed4 had an incorrect width - got "auto", expected "240px"
passed | Plugin element embed4 had an incorrect height
passed | Plugin element embed5 did not exist
passed | Plugin element embed5 had an incorrect width
failed | Plugin element embed5 had an incorrect height - got "auto", expected "200px"
passed | Plugin element embed6 did not exist
passed | Plugin element embed6 had an incorrect width
passed | Plugin element embed6 had an incorrect height
passed | Plugin element embed7 did not exist
passed | Plugin element embed7 had an incorrect width
passed | Plugin element embed7 had an incorrect height
passed | Plugin element embed8 did not exist
failed | Plugin element embed8 had an incorrect width - got "auto", expected "240px"
passed | Plugin element embed8 had an incorrect height
passed | Plugin element embed9 did not exist
passed | Plugin element embed9 had an incorrect width
passed | Plugin element embed9 had an incorrect height
passed | Plugin element embed10 did not exist
passed | Plugin element embed10 had an incorrect width
passed | Plugin element embed10 had an incorrect height
passed | Plugin element embed11 did not exist
passed | Plugin element embed11 had an incorrect width
passed | Plugin element embed11 had an incorrect height
passed | Plugin element object1 did not exist
failed | Plugin element object1 had an incorrect width - got "auto", expected "240px"
failed | Plugin element object1 had an incorrect height - got "auto", expected "200px"
passed | Plugin element object2 did not exist
passed | Plugin element object2 had an incorrect width
passed | Plugin element object2 had an incorrect height
passed | Plugin element object3 did not exist
passed | Plugin element object3 had an incorrect width
passed | Plugin element object3 had an incorrect height
passed | Plugin element object4 did not exist
failed | Plugin element object4 had an incorrect width - got "auto", expected "240px"
passed | Plugin element object4 had an incorrect height
passed | Plugin element object5 did not exist
passed | Plugin element object5 had an incorrect width
failed | Plugin element object5 had an incorrect height - got "auto", expected "200px"
passed | Plugin element object6 did not exist
passed | Plugin element object6 had an incorrect width
passed | Plugin element object6 had an incorrect height
passed | Plugin element object7 did not exist
passed | Plugin element object7 had an incorrect width
passed | Plugin element object7 had an incorrect height
passed | Plugin element object8 did not exist
failed | Plugin element object8 had an incorrect width - got "auto", expected "240px"

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

I am seeing this on m-c linux desktop builds that I do locally as well.  I saw this on fennec a year ago in bug 455956.

Comment 2

[Jason Orendorff [:jorendorff]]

I see this on local linux desktop builds too. dbaron says he tends to think the test is fine and that it's pointing out a bug in the code.

Comment 3

[Jason Orendorff [:jorendorff]]

From a randomly selected tinderbox Mochitest log:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1273004158.1273004584.20507.gz&fulltext=1

5872 INFO Running /tests/content/base/test/test_bug368972.html...
5873 INFO TEST-PASS | /tests/content/base/test/test_bug368972.html | Plugin element embed1 did not exist
5874 INFO TEST-PASS | /tests/content/base/test/test_bug368972.html | Plugin element embed1 had an incorrect width
5875 INFO TEST-PASS | /tests/content/base/test/test_bug368972.html | Plugin element embed1 had an incorrect height
5876 INFO TEST-PASS | /tests/content/base/test/test_bug368972.html | Plugin element embed2 did not exist
5877 INFO TEST-PASS | /tests/content/base/test/test_bug368972.html | Plugin element embed2 had an incorrect width
5878 INFO TEST-PASS | /tests/content/base/test/test_bug368972.html | Plugin element embed2 had an incorrect height
5879 INFO TEST-PASS | /tests/content/base/test/test_bug368972.html | Plugin element embed3 did not exist
5880 INFO TEST-PASS | /tests/content/base/test/test_bug368972.html | Plugin element embed3 had an incorrect width
5881 INFO TEST-PASS | /tests/content/base/test/test_bug368972.html | Plugin element embed3 had an incorrect height
...

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think that's just people writing their test descriptions on the assumption that they'll only get read when the test fails (which is a bad way to write them, in my opinion).

Comment 5

[Boris Zbarsky [:bzbarsky]]

This worksforme on Linux, both m-c and e10s trees...

That said, is the problem just that there's some async event that would lead to frame construction here that we're not flushing?  Like the instantiate event, say?