542312 - xbl handler does not work for keyboard events like keypress.

Status: RESOLVED INVALID

(Core :: XBL, defect)

Description

[Kurt M. Brown]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.6) Gecko/20100107 Fedora/3.5.6-1.fc12 Firefox/3.5.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6

The xbl handler tag no longer works for keyboard events like keypress in Firefox version 3.6.

Reproducible: Always

Steps to Reproduce:
1. give focus to a widget that has a keypress handler.
2. press keys.
3. see that the handler is never called.
Actual Results:  
The handler is never called for keypress events.

Expected Results:  
The handler gets called.

Comment 1

[Kurt M. Brown]

Attachment: Here is an example widget that shows the problem.

Comment 2

[jgotts]

Also a problem on the Win32 build of Firefox 3.6.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Any chance to get a testcase for this. Probably something which uses the xbl file already attached to this bug.


(Just couldn't immediately find anything focusable in the .xml file.)

Comment 4

[Kurt M. Brown]

Attachment: xul file needed to run xbl test

Comment 5

[Kurt M. Brown]

Attachment: binding file for xbl test

Comment 6

[Kurt M. Brown]

I attached three files: main.xul, main.css, and xblKeyTest.xml. The files should be placed into a single directory and then the main.xul should be loaded with firefox. If firefox has stdout dumping on, then whenever a click event happens, the string "click worked" will print. A keypress event should cause a dump of "keypress worked" but does not.

Comment 7

[Neil Deakin]

I didn't test this, but at a glance neither the element the binding is attached to nor the elements in the binding are focusable, so key events will never fire at them.

It's possible that the <description> elements were focused in earlier builds. That was a bug fixed by 494345.

Comment 8

[Kurt M. Brown]

Attachment: Here is a replacement xul that focuses the test widget onload.

Comment 9

[Neil Deakin]

The test widget isn't focusable. In 3.6, the focus() method has no effect on non-focasable elements.

Comment 10

[Kurt M. Brown]

How does one make a widget focasable?

Comment 11

[Kurt M. Brown]

I added to the binding in main.css

    -moz-user-focus: normal;

and now it works.

Comment 12

[jgotts]

Can we add this to the release notes for 3.6?

Comment 13

[Boris Zbarsky [:bzbarsky]]

I added dev-doc-needed to bug 494345.  Not sure what the 3.6 relnote situation is.

Comment 14

[Boris Zbarsky [:bzbarsky]]

Sounds like this is invalid.