extensions/create.pl does not give the lib/Util.pm module a correct package name

RESOLVED FIXED in Bugzilla 3.6

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: timello, Assigned: timello)

Tracking

unspecified
Bugzilla 3.6
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 423621 [details] [diff] [review]
Simple fix.

It is missing the module name in the package entry.
(Assignee)

Updated

9 years ago
Attachment #423621 - Flags: review?(mkanat)
(Assignee)

Updated

9 years ago
Status: NEW → ASSIGNED

Comment 1

9 years ago
Comment on attachment 423621 [details] [diff] [review]
Simple fix.

>Index: template/en/default/extensions/config.pm.tmpl
>-package B[% %]ugzilla::Extension::[% name %];
>+package B[% %]ugzilla::Extension::[% name %]::Config;

  This is incorrect, this part of the patch isn't necessary. (See the Bugzilla::Extension docs.) I'll remove this section on checkin.



  The Util part is right, though.
Attachment #423621 - Flags: review?(mkanat) → review+

Updated

9 years ago
Flags: approval+
Target Milestone: --- → Bugzilla 3.6

Updated

9 years ago
Assignee: extensions → timello

Updated

9 years ago
Summary: extensions/create.pl does not create lib/*.pm modules correctly → extensions/create.pl does not give the lib/Util.pm module a correct package name

Comment 2

9 years ago
Checking in template/en/default/extensions/util.pm.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/extensions/util.pm.tmpl,v  <--  util.pm.tmpl
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.