Last Comment Bug 542424 - "ASSERTION: New (SVG > 1.1) SVG viewport establishing element?"
: "ASSERTION: New (SVG > 1.1) SVG viewport establishing element?"
: assertion, testcase
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla13
Assigned To: Cameron McCormack (:heycam)
: Jet Villegas (:jet)
Depends on:
Blocks: 326633 344905
  Show dependency treegraph
Reported: 2010-01-26 20:38 PST by Jesse Ruderman
Modified: 2012-02-07 12:13 PST (History)
3 users (show)
cam: in‑testsuite+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

testcase (193 bytes, application/xhtml+xml)
2010-01-26 20:38 PST, Jesse Ruderman
no flags Details
Don't treat <svg:image> as a viewport establishing element. (3.87 KB, patch)
2012-02-05 20:06 PST, Cameron McCormack (:heycam)
jwatt: review+
Details | Diff | Splinter Review

Description Jesse Ruderman 2010-01-26 20:38:07 PST
Created attachment 423739 [details]

###!!! ASSERTION: New (SVG > 1.1) SVG viewport establishing element?: 'Error', file /Users/jruderman/mozilla-central/layout/svg/base/src/nsSVGUtils.cpp, line 533
Comment 1 Cameron McCormack (:heycam) 2012-02-05 20:06:28 PST
Created attachment 594620 [details] [diff] [review]
Don't treat <svg:image> as a viewport establishing element.

I think it makes sense just to have <image> not be considered to be a viewport
establishing element.  It does establish a viewport but for the referenced
document, not child content in this document.
Comment 2 Mozilla RelEng Bot 2012-02-05 20:52:26 PST
Autoland Patchset:
	Patches: 594620
	Branch: mozilla-central => try
Try run started, revision 70fc825a5a84. To cancel or monitor the job, see:
Comment 3 Mozilla RelEng Bot 2012-02-06 00:45:21 PST
Try run for 70fc825a5a84 is complete.
Detailed breakdown of the results available here:
Results (out of 208 total builds):
    success: 188
    warnings: 20
Builds (or logs if builds failed) available at:
Comment 4 Jonathan Watt [:jwatt] 2012-02-06 04:41:16 PST
Comment on attachment 594620 [details] [diff] [review]
Don't treat <svg:image> as a viewport establishing element.

Yeah, agreed. Can you add an explanatory comment to nsSVGUtils::EstablishesViewport noting this though? (Maybe with a pointer to this bug.)
Comment 5 Cameron McCormack (:heycam) 2012-02-06 12:35:17 PST
Comment 6 Ed Morley [:emorley] 2012-02-07 12:13:52 PST

Note You need to log in before you can comment on or make changes to this bug.