542438 - Page Info and Bookmark Info need verbs

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

When we renamed the ambiguous "Get Info" to "Page Info" and "Bookmark Info", we forgot that menu commands need verbs.  These should be renamed to "Show Page Info" and "Show Bookmark Info" or the like.

I think this is just a pair of string changes, so I'll try to get it for 2.1 (though I suppose we need to rename the dummy? item in the nib, too).

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Verbs!

Strictly speaking we don't need to fix the dummy in the nib, but until we're using the GTMUIL stuff and the entries are really dummies, I think it's less confusing to do so; nib to follow.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: MainMenu.nib (10.5.8, IB 2.5.6)

This will need resaving on 10.4 before landing, or we can test-land and see if the Ts problems still exist.

Comment 3

[Eiichi]

Attachment: MainMenu.nib (10.4.11, IB 2.5.6)

Opened and resaved on 10.4.11, IB 2.5.6, if necessary.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> Created an attachment (id=423846) [details]
> MainMenu.nib (10.4.11, IB 2.5.6)
> 
> Opened and resaved on 10.4.11, IB 2.5.6, if necessary.

Thanks!

Comment 5

[Stuart Morgan]

Comment on attachment 423834 [details] [diff] [review]
Verbs!

sr=smorgan

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk with the 10.5-generated nib.  I'll watch Ts and land the 10.4-generated copy from Eiichi if there's a Ts problem.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

So far there's no appreciable negative impact from the 10.5-generated nib; it's basically noise.  Ts did spike with that particular checkin, but dropped back subsequently (and the spikes weren't really out-of-range, either).  

It's possible this is still a problem and is being masked by the slow, steady Ts degradation we've seen since Safebrowsing (bug 476543) and the recent inability of reboots to drop minus's Ts back to "normal", but I think for now we can safely edit MainMenu.nib and BrowserWindow.nib with care in IB 2.5 on 10.5.

Actual data:

cb-minibinus01
After:  1576 1572 1546 1553 1549 1559 | Avg = 1559, +0.19%
Before: 1556 1562 1571 1541 1559 1547 | Avg = 1556

cb-xserve01
After:  633 633 634 632 | Avg = 633, +0.27%
Before: 631 633 631 630 | Avg = 631.25

cb-xserve04
After:  646 644 641 642 640 638 644 644 639 | Avg = 642, +0.63%
Before: 639 645 632 638 643 633 639 638 635 | Avg = 638