542468 - js/src/config/check-sync-dirs.py fails when running in a built environment

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Patch

(when VPATH = .)

As make check requires several Test binaries to be built, it must be run after a build. But in such case, and when VPATH = ., there are extra files in the config directories, that are very likely to differ: Makefile, autoconf.mk, system wrappers, object files and nsinstall binary.

For system wrappers, I think bug #542465 I just filed is the way to go, but for the others, exceptions should be added.

Comment 1

[Mike Hommey [:glandium]]

I forgot the fact that make check does run js/src/config/check-sync-exceptions as one of the first tests.

Comment 2

[Mike Hommey [:glandium]]

Grah, that was js/src/config/check-sync-dirs.py, obviously. not js/src/config/check-sync-exceptions.

Comment 3

[Mike Hommey [:glandium]]

For system wrappers, it turns out bug #542465 wasn't so good an idea. I'll try to find something else.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Patch v2, with system_wrappers_js

In the end, I just added something in the check script to allow directory exceptions.

Comment 5

[Micah Gersten]

This is affecting Ubuntu nightly builds as well on 1.9.2.  Check-in would be great :)

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/d15bfd6f16d2