Looking for saved searches? click on "Search Bugs" above.

js/src/config/check-sync-dirs.py fails when running in a built environment

RESOLVED FIXED in mozilla1.9.3a3

Status

()

Product:
Core
Component:
Build Config
RESOLVED FIXED
Reported:
8 years ago
Modified:
8 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Version:
Trunk
Target:
mozilla1.9.3a3
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Patch v2, with system_wrappers_js
1.13 KB, patch
ted
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
8 years ago 
Created attachment 423772 [details] [diff] [review]
Patch

(when VPATH = .)

As make check requires several Test binaries to be built, it must be run after a build. But in such case, and when VPATH = ., there are extra files in the config directories, that are very likely to differ: Makefile, autoconf.mk, system wrappers, object files and nsinstall binary.

For system wrappers, I think bug #542465 I just filed is the way to go, but for the others, exceptions should be added.
(Assignee)

Comment 1

•
8 years ago 
I forgot the fact that make check does run js/src/config/check-sync-exceptions as one of the first tests.
Attachment #423772 - Attachment is patch: true
Attachment #423772 - Attachment mime type: application/octet-stream → text/plain
Attachment #423772 - Flags: review?(ted.mielczarek)
 (Assignee)

Comment 2

•
8 years ago 
Grah, that was js/src/config/check-sync-dirs.py, obviously. not js/src/config/check-sync-exceptions.
Summary: js/src/config/check-sync-exceptions fails when running in a built environment → js/src/config/check-sync-dirs.py fails when running in a built environment
 (Assignee)

Comment 3

•
8 years ago 
For system wrappers, it turns out bug #542465 wasn't so good an idea. I'll try to find something else.
 (Assignee)

Comment 4

•
8 years ago 
Created attachment 423793 [details] [diff] [review]
Patch v2, with system_wrappers_js

In the end, I just added something in the check script to allow directory exceptions.
Assignee: nobody → mh+mozilla
Attachment #423772 - Attachment is obsolete: true
Attachment #423793 - Flags: review?(ted.mielczarek)
Attachment #423772 - Flags: review?(ted.mielczarek)
Attachment #423793 - Flags: review?(ted.mielczarek) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 5

•
8 years ago 
This is affecting Ubuntu nightly builds as well on 1.9.2.  Check-in would be great :)

Comment 6

•
8 years ago 
http://hg.mozilla.org/mozilla-central/rev/d15bfd6f16d2
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a3
You need to log in before you can comment on or make changes to this bug.