Closed Bug 542491 Opened 14 years ago Closed 14 years ago

Implement themes for the editor

Categories

(Skywriter Graveyard :: Editor, defect)

Other
Other
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dangoor, Assigned: julian.viereck)

References

Details

(Whiteboard: [goals])

The Rebooted Bespin UI is built out of SproutCore components. As such, it can 
be styled readily via CSS. We already have the ability to load CSS from 
plugins, so creating themes for the complete UI is straightforward.

However, the editor component would ideally pull color information out of a 
theme (and, even more ideally, be overridable by the user). The color 
information *could* be in the CSS with that data queried for by the theme 
handling code. Or it could be in plugin metadata for a theme plugin.
An argument in favor of storing the colors in JSON in the plugin metadata is 
that we could make a theme editor that is similar to TextMate's. That would 
just output JSON that can be stored in the user's settings or moved into a new 
theme plugin if the user wants to make a custom theme.

Note that that also has ramifications for syntax highlighting (the highlighters 
would need to supply the semantic meaning for parts of the file, rather than 
actual colors... it may work that way already, that work is in progress by 
pwalton).
Assignee: nobody → anthonyisgood
Blocks: 553333
Julian Viereck will help out with this bug.
Whiteboard: [goals]
Reset the assignment due to Anthony's mail.

@Kevin: If you want me to go for this bug, please assign it to me. Otherwise I will hold off.
Assignee: anthonyisgood → nobody
Assignee: nobody → jviereck
Over the last weeks I worked on this bug. I've implemented a white theme that works and moved this one over to the supported/ section as with changeset b80c7c2552d7.

Due to the fact, that the theming infrastructure should be stable now and a prove of concept theme is working, I close this bug.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.