Closed Bug 542607 Opened 11 years ago Closed 11 years ago

No checkerboarding for pages with animation

Categories

(Firefox for Android Graveyard :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: stechz, Assigned: stechz)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
This keeps the tile in the DOM when mozafterpaints occur.  On NYTimes and BBC I'm not really seeing checkerboarding anymore.  It does cause some sheering on sites like bubblemark when panning about zoomed in--an acceptable tradeoff IMO.

Pretty low risk.
Attachment #423843 - Flags: review?(pavlov)
Attachment #423843 - Flags: review?(mark.finkle)
Attachment #423843 - Flags: review?(21)
Comment on attachment 423843 [details] [diff] [review]
Patch

I don't like how tweaky this code is becoming. Extra params and booleans... blah.

I wish for a day when this code was easier to understand.
Attachment #423843 - Flags: review?(mark.finkle) → review+
Attachment #423843 - Flags: review?(pavlov)
Comment on attachment 423843 [details] [diff] [review]
Patch

(In reply to comment #1)
> (From update of attachment 423843 [details] [diff] [review])
> I don't like how tweaky this code is becoming. Extra params and booleans...
> blah.
> 
> I wish for a day when this code was easier to understand.

The boolean flag has been done before 1.0 for ensuring that the patch touch the less code as possible (If I'm remember what Ben told me).
Maybe we could have a cleaner patch?
Attachment #423843 - Flags: review?(21) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/d61fdff66712
Assignee: nobody → webapps
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
This fixes the ceckerboarding when panning off of pages with animation, but there's some sites like cartoonnetwork.com that are slow in panning the first 1-2 times you move up and down the page (post page load).

verified FIXED on builds:
Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2.2pre) Gecko/20100219 Namoroka/3.6.2pre Fennec/1.1a1

and

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.2pre) Gecko/20100219 Namoroka/3.6.2pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a2pre) Gecko/20100219 Namoroka/3.7a2pre Fennec/1.1a2pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.