542616 - [OOPP] Parent-side crash after killing plugin process

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

00000000()	
 	user32.dll!_UserCallWinProcCheckWow@32()  + 0x32502 bytes	
 	user32.dll!_CallWindowProcAorW@24()  + 0x51 bytes	
 	user32.dll!_CallWindowProcW@20()  + 0x1b bytes	
>	xul.dll!mozilla::plugins::PluginInstanceParent::PluginWindowHookProc(HWND__ * hWnd=0x001702ea, unsigned int message=15, unsigned int wParam=0, long lParam=0)  Line 892	C++
 	user32.dll!_InternalCallWinProc@20()  + 0x28 bytes	
 	user32.dll!_UserCallWinProcCheckWow@32()  + 0xb7 bytes	
 	user32.dll!_CallWindowProcAorW@24()  + 0x51 bytes	
 	user32.dll!_CallWindowProcW@20()  + 0x1b bytes	
 	xul.dll!PluginWndProc(HWND__ * hWnd=0x001702ea, unsigned int msg=15, unsigned int wParam=0, long lParam=0)  Line 369 + 0x68 bytes	C++
 	user32.dll!_InternalCallWinProc@20()  + 0x28 bytes	
 	user32.dll!_UserCallWinProcCheckWow@32()  + 0xb7 bytes	
 	user32.dll!_DispatchClientMessage@20()  + 0x4d bytes	
 	user32.dll!___fnDWORD@4()  + 0x24 bytes	
 	ntdll.dll!_KiUserCallbackDispatcher@12()  + 0x13 bytes	
 	user32.dll!_NtUserDispatchMessage@4()  + 0xc bytes	
 	user32.dll!_DispatchMessageW@4()  + 0xf bytes	
 	xul.dll!nsAppShell::ProcessNextNativeEvent(int mayWait=0)  Line 278	C++
 	xul.dll!nsBaseAppShell::DoProcessNextNativeEvent(int mayWait=0)  Line 155 + 0x11 bytes	C++
 	xul.dll!nsBaseAppShell::OnProcessNextEvent(nsIThreadInternal * thr=0x01608488, int mayWait=0, unsigned int recursionDepth=0)  Line 293 + 0xd bytes	C++
 	xul.dll!nsThread::ProcessNextEvent(int mayWait=0, int * result=0x0012d7f8)  Line 510	C++
 	xul.dll!NS_ProcessNextEvent_P(nsIThread * thread=0x01608488, int mayWait=0)  Line 250 + 0x16 bytes	C++
 	xul.dll!mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate * aDelegate=0x016065f0)  Line 118 + 0xe bytes	C++
 	xul.dll!MessageLoop::RunInternal()  Line 212	C++
 	xul.dll!MessageLoop::RunHandler()  Line 195	C++
 	xul.dll!MessageLoop::Run()  Line 169	C++
 	xul.dll!nsBaseAppShell::Run()  Line 180	C++
 	xul.dll!nsAppShell::Run()  Line 240	C++
 	xul.dll!nsAppStartup::Run()  Line 182 + 0x1c bytes	C++
 	xul.dll!XRE_main(int argc=4, char * * argv=0x01601938, const nsXREAppData * aAppData=0x01601f60)  Line 3476 + 0x25 bytes	C++
 	firefox.exe!NS_internal_main(int argc=4, char * * argv=0x01601938)  Line 158 + 0x12 bytes	C++
 	firefox.exe!wmain(int argc=4, wchar_t * * argv=0x00c4b828)  Line 120 + 0xd bytes	C++
 	firefox.exe!__tmainCRTStartup()  Line 583 + 0x19 bytes	C
 	firefox.exe!wmainCRTStartup()  Line 403	C
 	kernel32.dll!_BaseProcessStart@4()  + 0x23 bytes

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Crap, I hit "Enter" in the wrong text box and submitted this too soon.  What I meant to add was:

This happened when I navigated to http://www.nestersmarket.com/yaletown/ and then killed mozilla-runtime.exe with Process Explorer.  I'm going to see how easily reproducible this.

Comment 2

[Jim Mathies [:jimm]]

Attachment: patch

Comment 3

[Jim Mathies [:jimm]]

Attachment: patch v.2

Comment 4

[Jim Mathies [:jimm]]

Attachment: patch v3

Comment 5

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/035ca5e3ea54