Closed
Bug 542696
Opened 13 years ago
Closed 12 years ago
Consolidate xulrunner and fennec debs
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Future
People
(Reporter: aki, Assigned: mfinkle)
References
Details
Attachments
(1 file, 1 obsolete file)
4.79 KB,
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
We've been talking about this for a while now. Tracking here.
Comment 2•13 years ago
|
||
I filed bug 543060 to not require fennec be built on top of xulrunner at all, which is at least tangentially related. to answer two of John's questions for bug 542555: > - what should the new all-in-one deb file be called? I'd imagine just fennec and we'd drop the dependency on xulrunner > - make sure users on earlier two-deb installations are upgraded correctly should be seemless, although users may wind up with an extra/leftover xulrunner install unless they run apt-get autoremove. (the application manager may be smart and do that auto-magically.... I don't know)
See Also: → 543060
Comment 3•13 years ago
|
||
I filed 542319 to update the nightly version.
Assignee | ||
Comment 4•12 years ago
|
||
This patch moves the xulrunner binary files into the fennec deb. The xulrunner dependency is removed from the debian package. I also update the default version of mobile-browser to 1.1a2pre I tested the deb and it upgrades from Firefox 1.0.0 to Firefox 1.1a2pre, however it does not remove the /opt/mozilla/xulrunner-1.9.2.1 folder and files. A | apt-get autoremove | does find the unused xulrunner files and removes them.
Assignee: nobody → mark.finkle
Attachment #426081 -
Flags: review?(bugmail)
Comment 5•12 years ago
|
||
Comment on attachment 426081 [details] [diff] [review] patch >-deb: $(PP_DEB_FILES) $(DIST)/branding/$(MOZ_APP_NAME)_scalable.png \ >+deb: $(PP_DEB_FILES) $(DIST)/branding/$(MOZ_APP_NAME)_scalable.png $(MOZILLA_VERSION).$(MOZ_APP_NAME).conf \ nit, wrap this so its less than 80 chars >+ rm $(DEBDESTDIR)/$(installdir)/xulrunner/xpidl do you know why NO_PKG_FILES isn't taking care of this? My only worry is that we're packaging other extra files
Attachment #426081 -
Flags: review?(bugmail) → review+
Comment 6•12 years ago
|
||
oh, one other question. Do we want to preserve the ability to have separate xulrunner and fennec debs? This patch obviously doesn't.
Assignee | ||
Comment 7•12 years ago
|
||
(In reply to comment #5) > (From update of attachment 426081 [details] [diff] [review]) > >-deb: $(PP_DEB_FILES) $(DIST)/branding/$(MOZ_APP_NAME)_scalable.png \ > >+deb: $(PP_DEB_FILES) $(DIST)/branding/$(MOZ_APP_NAME)_scalable.png $(MOZILLA_VERSION).$(MOZ_APP_NAME).conf \ > nit, wrap this so its less than 80 chars sure, but DEATH TO 80 CHAR LIMTS! I feel better > >+ rm $(DEBDESTDIR)/$(installdir)/xulrunner/xpidl > do you know why NO_PKG_FILES isn't taking care of this? My only worry is that > we're packaging other extra files It's not in the list: http://mxr.mozilla.org/mozilla-central/source/xulrunner/installer/Makefile.in#47 http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/packager.mk#245 But, Firefox adds them: http://mxr.mozilla.org/mozilla-central/source/browser/installer/Makefile.in#46 I'll try adding what FF does
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to comment #6) > oh, one other question. Do we want to preserve the ability to have separate > xulrunner and fennec debs? This patch obviously doesn't. We can easily add that back if we need to.
Assignee | ||
Comment 9•12 years ago
|
||
Patch addresses review comments: * Uses NO_PKG_FILES during the xulrunner repack to remove unwanted files * Tested with mybrowser xul app on N900. It ran fine using a xulrunner-stub to find the fennec/xulrunner
Attachment #426081 -
Attachment is obsolete: true
Attachment #426193 -
Flags: review?(bugmail)
Updated•12 years ago
|
Attachment #426193 -
Flags: review?(bugmail) → review+
Assignee | ||
Comment 10•12 years ago
|
||
pushed: http://hg.mozilla.org/mobile-browser/rev/fd2a78968403
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Future
Comment 11•12 years ago
|
||
verified FIXED on builds (via dpkg and app manager update on the 1.9.2_multi catalog): Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.2pre) Gecko/20100211 Namoroka/3.6.2pre Fennec/1.0pre We really need to update our installation testcases in litmus and send out another blogpost about how to get nightly builds now.
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Comment 12•12 years ago
|
||
wrong build id: Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.2pre) Gecko/20100211 Namoroka/3.6.2pre Fennec/1.1a2pre
Comment 13•12 years ago
|
||
Changed testcase 7595 so that only a Fennec deb is downloaded, instead of both xulrunner and fennec debs, https://litmus.mozilla.org/show_test.cgi?id=7595
Flags: in-litmus? → in-litmus+
Updated•12 years ago
|
Component: Linux/Maemo → General
QA Contact: maemo-linux → general
You need to log in
before you can comment on or make changes to this bug.
Description
•