542931 - Bug in SOAP::Lite prevents WebService:XMLRPC logins from persisting

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Michael Thomas (Mockodin)]

SOAP::Transport::HTTP line 807 (SOAP::Lite 0.710.10) Only the last Cookie is set
	
>    if ( $self->{'MOD_PERL_VERSION'} > 1 ) {
>        $self->response->headers->scan( sub { $r->headers_out->set(@_) } );   #<- line 807
>        $r->content_type( join '; ', $self->response->content_type );
>    }
>    else {
>        $self->response->headers->scan( sub { $r->header_out(@_) } );
>        $r->send_http_header( join '; ', $self->response->content_type );
>    }
>    $r->print( $self->response->content );
>    return $self->{OK};

Should be:
$self->response->headers->scan( sub { $r->headers_out->add(@_) } );

$r->headers_out->set() appears to keep overwriting the same cookie
header with each subsequent cookie, there by setting only the last

$r->headers_out->add() on the other hand properly adds each uniquely

I thought it worked previously so I'm wondering if header_out->set
changed somehow?

I have posted an rt bug, I'll post a direct link once the bug request is processed:
http://rt.cpan.org/Public/Dist/Display.html?Name=SOAP-Lite

Comment 1

[Michael Thomas (Mockodin)]

RT Ticket:
http://rt.cpan.org/Ticket/Display.html?id=54106

Comment 2

[Michael Thomas (Mockodin)]

Also reported on SourceForge:
http://sourceforge.net/tracker/?func=detail&atid=513017&aid=2946245&group_id=66000

Comment 3

[Michael Thomas (Mockodin)]

Added patch to SourceForge ticket

Comment 4

[Michael Thomas (Mockodin)]

Patch accepted, but no idea when it will get rolled into a build and up on cpan.

Comment 5

[Michael Thomas (Mockodin)]

SOAP-Lite-0.711 released 18 Mar 2010 to CPAN, Includes Cookie fix

We should increment the minimum version in checksetup accordingly.

Comment 6

[Max Kanat-Alexander]

Mockodin: Feel free to supply a patch for the version number bump. We may also have to make other fixes to be fully compatible with the latest versions.

Comment 7

[Frédéric Buclin]

Attachment: patch, v1

SOAP::Lite 0.712 was released 6 months ago. It also fixes these annoying warnings in Perl 5.12.

Comment 8

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Install/Requirements.pm
Committed revision 7613.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified Bugzilla/Install/Requirements.pm
Committed revision 7490.