Closed
Bug 542962
Opened 15 years ago
Closed 15 years ago
Remove some zero byte files
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: philor, Assigned: philor)
Details
Attachments
(1 file)
1.13 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
Weirdly, a fair percentage of our zero byte files are intentional, between test cases and gross hacks like toolkit/empty-file and things that are empty upstream in libraries.
Of the killable things:
gfx/src/nsColorNames.cpp and gfx/tests/DumpColors.cpp became empty in bug 422637, and I don't see anything in the bug indicating that they were intentionally being emptied, rather than accidentally not-hg-rm-ed.
netwerk/base/src/nsStreamObserverProxy.cpp, netwerk/base/src/nsStreamObserverProxy.h, xpcom/proxy/public/nsIProxyCreateInstance.idl, and xpcom/proxy/public/nsProxyEvent.h became empty in bug 326273, and surprises from the threadmanager landing are no surprise.
xpcom/reflect/xptcall/src/md/unix/xptcstubs_asm_ppc_aix.s and xpcom/reflect/xptcall/src/md/unix/xptcstubs_asm_ppc_aix64.s became empty in bug 275004, where nobody explained to a patch author without CVS access how to use cvsdo to remove files.
toolkit/mozapps/xpinstall/locale/xpinstallConfirm.properties.txt is a painfully funny thing that beng apparently landed to maintain an otherwise empty directory in 2003, which we've kept hanging around ever since.
Attachment #424194 -
Flags: review?(dbaron)
Comment on attachment 424194 [details] [diff] [review]
hg rm
r=dbaron
Hopefully this is mostly the result of patch failure, etc. If only mercurial defaulted to git-style diffs...
Attachment #424194 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 2•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•