543113 - Phonebook manager field loses the manager when you edit

Status: RESOLVED FIXED

(Webtools Graveyard :: Phonebook, defect)

Description

[Wilson Lee [:kourge]]

Currently, when editing your manager in the Phonebook, the field is implemented as a textbox with autocomplete. This is nice, but...
1. After saving and editing again, the manager field is blank. This way, one cannot tell if they've set their manager or not.
2. If you enter a person that does not exist at all, no warnings are shown and the manager field remains unmodified. Warnings should be shown for clarity.

Comment 1

[Wilson Lee [:kourge]]

This bug has been fixed in the rewritten phonebook, so it no longer applies.

Comment 2

[Daniel Holbert [:dholbert]]

This doesn't appear to be fixed, actually.

I'm not sure if it was at one point fixed & has broken again, or if comment 1 was just incorrect.  But the description in Comment 0 appears to apply exactly right now. (manager field always shows up as blank on pageload, and it accepts invalid values)

Hence, reopening.

Comment 3

[Fred Wenzel [:wenzel]]

Jennifer, can you take a look? Thanks!

Comment 4

[Dave Miller [:justdave]]

bumping severity, this is causing dataloss because it clears the manager if you don't put it back before saving the user.

Comment 7

[Fred Wenzel [:wenzel]]

(In reply to Dave Miller [:justdave] from comment #4)
> bumping severity, this is causing dataloss because it clears the manager if
> you don't put it back before saving the user.

I cannot reproduce that: If you don't touch the field at all, it won't clear your manager.

Comment 8

[Jen Fong-Adwent [:ednapiranha]]

Attachment: Proposed fix for displaying the manager name in the input field during profile edit.

Comment 9

[Fred Wenzel [:wenzel]]

Comment on attachment 564356 [details]
Proposed fix for displaying the manager name in the input field during profile edit.

r+ for this part of the patch, because it does show the manager now. Good job!

Only problem now is that I can't change my manager anymore. When I click the field (that should probably select the entire text on click), and I enter, say "Wil", I get a dropdown list mentioning people with that name. Then I click on one, but it fills in a completely different person.

Any idea what broke there?

Comment 10

[Jen Fong-Adwent [:ednapiranha]]

I think it was browser caching possibly - works for me.

Comment 11

[Fred Wenzel [:wenzel]]

Comment on attachment 564356 [details]
Proposed fix for displaying the manager name in the input field during profile edit.

Yes, seems to have been a caching issue. I can't reproduce this anymore.

Jen, once you have SVN access, please land this. You want to mention this bug number in your commit message, and then refer to the commit number here (pro tip: r1234 will auto-link to that commit on SVN).

Comment 12

[Fred Wenzel [:wenzel]]

Jen, looks like you should have commit access now. Will you try committing this? Make sure to update from SVN before you do that, as I committed a few things for other bugs to the phonebook so you might need to merge that.

Comment 13

[Jen Fong-Adwent [:ednapiranha]]

Fix committed r95868

Comment 14

[Fred Wenzel [:wenzel]]

Woot!