543141 - startup crash [@ memcpy | mime_LineBuffer] (windows), [@ mime_LineBuffer] (Mac)

Status: RESOLVED WORKSFORME

(MailNews Core :: MIME, defect)

Description

[Wayne Mery (:wsmwk)]

startup crash [@ memcpy | mime_LineBuffer] (windows),  [@ mime_LineBuffer] (Mac)
90% of crashes are startup

#38 crash for 3.0.1
crashes appear to have started in 3.0b4 - do we suspect feeding of gloda processing?

b4c37693-571c-4d9f-9546-a07e22100129  3.0.1 (windows) no extensions
0	mozcrt19.dll	memcpy	 memcpy.asm:278
1	thunderbird.exe	mime_LineBuffer	mailnews/mime/src/mimebuf.cpp:256
2	thunderbird.exe	MimeObject_parse_buffer	mailnews/mime/src/mimeobj.cpp:275
3	thunderbird.exe	MimeMultipart_parse_eof	mailnews/mime/src/mimemult.cpp:760
4	thunderbird.exe	MimeMultipart_parse_eof	mailnews/mime/src/mimemult.cpp:779
5	thunderbird.exe	MimeContainer_parse_eof	mailnews/mime/src/mimecont.cpp:140
6	thunderbird.exe	MimeMessage_parse_eof	mailnews/mime/src/mimemsg.cpp:542
7	thunderbird.exe	mime_display_stream_complete	mailnews/mime/src/mimemoz2.cpp:965
8	thunderbird.exe	nsStreamConverter::OnStopRequest	mailnews/mime/src/nsStreamConverter.cpp:1068
9	thunderbird.exe	nsImapCacheStreamListener::OnStopRequest	mailnews/imap/src/nsImapProtocol.cpp:8333
10	thunderbird.exe	nsInputStreamPump::OnStateStop	netwerk/base/src/nsInputStreamPump.cpp:576
11	thunderbird.exe	nsInputStreamPump::OnInputStreamReady	netwerk/base/src/nsInputStreamPump.cpp:401 


bp-681726c1-1a10-4424-8a9d-cb3ef2100111  3.0 Mac 
0		@0xffff07fc	
1	thunderbird-bin	mime_LineBuffer	mailnews/mime/src/mimebuf.cpp:256
2	thunderbird-bin	MimeObject_parse_buffer	mailnews/mime/src/mimeobj.cpp:275
3	thunderbird-bin	MimeMultipart_parse_eof	mailnews/mime/src/mimemult.cpp:754
4	thunderbird-bin	MimeMultipartSigned_parse_eof	mailnews/mime/src/mimemsig.cpp:790
5	thunderbird-bin	MimeContainer_parse_eof	mailnews/mime/src/mimecont.cpp:140
6	thunderbird-bin	MimeMessage_parse_eof	mailnews/mime/src/mimemsg.cpp:542
7	thunderbird-bin	mime_display_stream_complete	mailnews/mime/src/mimemoz2.cpp:965
8	thunderbird-bin	nsStreamConverter::OnStopRequest	mailnews/mime/src/nsStreamConverter.cpp:1068
9	thunderbird-bin	nsImapCacheStreamListener::OnStopRequest	mailnews/imap/src/nsImapProtocol.cpp:8333
10	thunderbird-bin	nsInputStreamPump::OnStateStop	netwerk/base/src/nsInputStreamPump.cpp:576
11	thunderbird-bin	nsInputStreamPump::OnInputStreamReady	netwerk/base/src/nsInputStreamPump.cpp:401

Comment 1

[Wayne Mery (:wsmwk)]

Makoto, is a testcase or steps needed?

Comment 2

[Wayne Mery (:wsmwk)]

bp-530cfbc6-69b8-4b3c-990d-b6d502110623 from http://getsatisfaction.com/mozilla_messaging/topics/thunderbird_crashes_with_gmail

EXCEPTION_ACCESS_VIOLATION_READ
0x9500000
0	mozcrt19.dll	memcpy	memcpy.asm:257
1	thunderbird.exe	mime_LineBuffer	mailnews/mime/src/mimebuf.cpp:256
2	thunderbird.exe	MimeObject_parse_buffer	mailnews/mime/src/mimeobj.cpp:275
3	thunderbird.exe	MimeMultipart_parse_eof	mailnews/mime/src/mimemult.cpp:760
4	thunderbird.exe	MimeMultipart_parse_eof	mailnews/mime/src/mimemult.cpp:779
5	thunderbird.exe	MimeContainer_parse_eof	mailnews/mime/src/mimecont.cpp:140
6	thunderbird.exe	MimeMessage_parse_eof	mailnews/mime/src/mimemsg.cpp:542
7	thunderbird.exe	mime_display_stream_complete	mailnews/mime/src/mimemoz2.cpp:960
8	thunderbird.exe	nsStreamConverter::OnStopRequest	mailnews/mime/src/nsStreamConverter.cpp:1090
9	thunderbird.exe	nsImapCacheStreamListener::OnStopRequest	mailnews/imap/src/nsImapProtocol.cpp:8556

Comment 3

[Wayne Mery (:wsmwk)]

only a couple crashes in a couple months

https://crash-stats.mozilla.com/report/index/5825c9fb-8456-4896-a7c0-ded972141030

http://hg.mozilla.org/releases/comm-esr24/annotate/a908efbe7f74/mailnews/mime/src/mimeenc.cpp#l170
jonathan.protzenko@6218 164 // Fill the size
jonathan.protzenko@6218 165 if (outSize)
jonathan.protzenko@6218 166 *outSize = out - buffer;
jonathan.protzenko@6218 167
hg@0 168 /* Now that we've altered the data in place, write it. */
hg@0 169 if (out > buffer)
hg@0 170 return data->write_buffer (buffer, (out - buffer), data->closure); 

http://hg.mozilla.org/releases/comm-esr24/annotate/a908efbe7f74/mailnews/mime/src/mimetext.cpp#l326
hg@0 311 /* If we're supposed to write this object, but aren't supposed to convert
hg@0 312 it to HTML, simply pass it through unaltered. */
hg@0 313 if (!obj->options->write_html_p && obj->options->format_out != nsMimeOutput::nsMimeMessageAttach)
bugzilla@10318 314 return MimeObject_write(obj, buf, size, true);
hg@0 315
hg@0 316 /* This is just like the parse_decoded_buffer method we inherit from the
hg@0 317 MimeLeaf class, except that we line-buffer to our own wrapper on the
hg@0 318 `parse_line' method instead of calling the `parse_line' method directly.
hg@0 319 */
hg@0 320 return mime_LineBuffer (buf, size,
hg@0 321 &obj->ibuffer, &obj->ibuffer_size, &obj->ibuffer_fp,
bugzilla@10318 322 true,
ehsan@13324 323 ((int (*) (char *, int32_t, void *))
hg@0 324 /* This cast is to turn void into MimeObject */
hg@0 325 MimeInlineText_rotate_convert_and_parse_line),
hg@0 326 obj); 

http://hg.mozilla.org/releases/comm-esr24/annotate/a908efbe7f74/mailnews/mime/src/mimebuf.cpp#l224
ehsan@13324 218 if (desired_size >= (uint32_t) (*buffer_sizeP))
hg@0 219 {
hg@0 220 status = mime_GrowBuffer (desired_size, sizeof(char), 1024,
hg@0 221 bufferP, buffer_sizeP);
hg@0 222 if (status < 0) return status;
hg@0 223 }
hg@0 224 memcpy ((*bufferP) + (*buffer_fpP), net_buffer, (end - net_buffer));

Comment 4

[Ludovic Hirlimann [:Usul]]

Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.

Comment 5

[Wayne Mery (:wsmwk)]

Signature does not exist after Thunderbird 3.1.11