54317 - Format submenus do not indicate current style of selection

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[Frank Tang]

This is using Window commercial Netscape 6 bulid 2000092408
on Window NT4

repreduce procedure
1. launch Netscape6
2. Select "Task:composer" to open a new page.
3. type "abcdefg"
4. select "abc"
5. select "Format:Text Style:Bold"
6. the text "abc" display as bold
7. select "Format:Text Style" menu
expect result-
the menu item "Bold" show a check mark or some other indication to tell the 
user the current select text is in "Bold"

actual result-
no indication to tell user what the current state is.
"Format:Paragraph", "Format:List" and "Format:Align" menu do indicate the 
current state. 
"Format:Font" (as 54316) and "Format:Size" (as 54315)does not do this neither. 
Will report 
seperate bug for them.

Comment 1

[Frank Tang]

This problem can be reproduce on 20000927 Win/Linux build. But it is ok on Mac
build.

Comment 2

[anthonyd]

futuring, not sure who the owner of this is.

anthonyd

Comment 3

[rubydoo123]

there should be checkmark next to the style of the current selection, i thought 
that that used to be the case

Comment 4

[Charles Manske]

This one is trivial. low risk/high visibility.
The menuitems were missing the 'type="checkbox"' attribute, which is needed
in order to have the checkmark visible.
Nominating for rtm fix.

Comment 5

[Charles Manske]

Attachment: Fix for bug: simply add 'type="checkbox"' on menuitems

Comment 6

[Charles Manske]

Attachment: Fix for missing feedback in all Format submenus (fixes 54315, 54316, and 54317)

Comment 7

[Charles Manske]

If bugs 54315 and 54316 are also approved or merged with this bug to cover
all missing submenu feedback issues, use the 9/29 patch, which fixes all 3
bugs.
Patch has been sent to Composer group for more testing and reviews.

Comment 8

[Charles Manske]

Attachment: Test cases for Font face, size and text styles user feedback in Format submenus

Comment 9

[Charles Manske]

The attached test file works for bugs 54315 and 54316 as well.
Handing off to Kathy as I'm starting my sabatical.

Comment 10

[rubydoo123]

the user needs to be able to determine the style information from the menu, ther 
e is no text property dialog, consequently there is no workaround, this is a 
highly visible function.

Kathy, please include the required information per the rtm checkin rules

Comment 11

[Phil Peterson]

PDT agrees [rtm need info] until code reviews are done

Comment 12

[Kathleen :Brade]

Attachment: patch as before but with additional fixes for Macintosh

Comment 13

[Kathleen :Brade]

Attachment: JS patch (part 2 of 2)

Comment 14

[Kathleen :Brade]

I have attached new patches (2 separate attachments) because Charley's fixes
didn't work on Macintosh.  Apparently all radio menu items need to specify a
name (at least that is true on Macintosh).

Because I can't review my additional changes, I need reviews from both kin and
sfraser (one as sr and one as module owner).

There is no impact to i18n/l10n.
This is a very visible bug that seriously impacts editing in both Composer and
mail compose (the user has no feedback or incorrect feedback).

Comment 15

[Kathleen :Brade]

correcting summary to agree with the real problems addressed in this bug
Kin did a review and we agreed to one small change to the JS patch (part 2 of 2)
submitted 10/05/00 10:51.  I will attach the new diff for completeness

Kin--please add your sr= comment

Comment 16

[Kathleen :Brade]

Attachment: replacement JS patch (part 2 of 2)

Comment 17

[Kathleen :Brade]

*** Bug 54315 has been marked as a duplicate of this bug. ***

Comment 18

[Kathleen :Brade]

*** Bug 54316 has been marked as a duplicate of this bug. ***

Comment 19

[kinmoz]

r=[e-mail]

sfraser said he wanted to take a look at the new diffs which brade just posted 
(10/06/00 06:01.

Comment 20

[Simon Fraser [no longer active]]

r=sfraser

Comment 21

[Simon Fraser [no longer active]]

sr=sfraser

Comment 22

[Kathleen :Brade]

note: the correct patches for this bug are dated:
  10/05/00 10:50  and 10/06/00 06:01

I'll send this off to pdt.

Comment 23

[Phil Peterson]

rtm++

Comment 24

[Kathleen :Brade]

Fix checked into branch before today's builds.

Comment 25

[Kathleen :Brade]

fix now checked into trunk; resolving bug

Comment 26

[sujay]

verified in 10/10 build.